PRのテンプレートを更新する #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappyMana
reviewed
Aug 29, 2023
| # レビューしてほしいところ | ||
|
|
||
| ## 概要 | ||
| <!-- 後で取り組む人のためになるべくわかりやすく書きましょう --> |
There was a problem hiding this comment.
個人的に、新しく入ってきた人向けに、コメントアウトでどんなことを書くのかは書いたほうがいいかなーと思いました
Member
Author
There was a problem hiding this comment.
了解です、サンプルテキストをコメントとして記述しておくのはいかがですか？
There was a problem hiding this comment.
コメントっていうのは、PRのコメントです？
PRを作成する→PRにコメントをつけることができる
の流れだと思うので、大体の人はPRを作成するときに概要も記述する人が多いと思うので、PR作ったあとにコメントで例や説明が来ても遅いかなと思ってます。
Member
Author
|
「背景」という表現よりも「変更を加える理由」という表現の方が分かりやすいと思ったので修正します |
Member
Author
|
「レビューしてほしいところ」という表現よりも「レビューする際の注意点」という表現の方が分かりやすいと思ったのでこちらも修正します |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.