Improve the default values for scale testing #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Citus should be able to handle a lot more concurrent queries as of 9.3, we should increase the defaults.
marcocitus
approved these changes
May 12, 2020
Contributor
|
I think we probably want to use 64 clients in scale tests as the memory wasn't good at handling 128 with our default values, but when we increase the default values, we can probably make them 128. There are probably other scale config files where we should change these values I think. |
Contributor
|
Do we want to merge this PR? |
Contributor
|
We can possibly first merge #163 then merge this after updating all scale tests with the same default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Citus should be able to handle a lot more concurrent queries
as of 9.3, we should increase the defaults.
Max connections is already
1000which is more than we need.