Fatality details page: Create summary/map card #1880

roseeichelmann · 2025-10-29T19:25:37Z

Associated issues

Closes cityofaustin/atd-data-tech#24972

Testing

URL to test:
Local

Steps to test:

Go to the Fatalities tab, click on a crash id hyperlink to route to that Fatality details page
See the summary card with the 4 fields and the map, compare to the issue mock up
By default the map should be using the color streets basemap. Test using all the map controls and updating the basemap type
See that all the maps in the app now use the colorful basemap when app is on light mode

Ship list

Check migrations for any conflicts with latest migrations in main branch
Confirm Hasura role permissions for necessary access
Code reviewed
Product manager approved

netlify · 2025-10-29T19:25:42Z

❌ Deploy Preview for atd-vze-staging failed. Why did it fail? →

Name	Link
🔨 Latest commit	`1a6363c`
🔍 Latest deploy log	https://app.netlify.com/projects/atd-vze-staging/deploys/69026a3471f90b0008136200

…e_summary_24972

roseeichelmann · 2025-10-31T17:18:43Z

editor/utils/map.ts

-        ? mapStyleOptions.darkStreets
-        : mapStyleOptions.lightStreets;
+      if (useColorStreets) {
+        return mapStyleOptions.colorStreets;


adding the third option of using the colorful streets basemap instead of light vs dark

also -- im not fuly convinced that we shouldnt just make the colorful street map what you see on light mode? so the crashes list page would should the colorful streetmap on light mode too, and dark mode would still show the dark street map on all the maps. 🤷 @johnclary thoughts?

I am in total agreement, and actually wrote this into the issue 😎

As part of the this work—replace the light/dark basemaps with the color street map (streets-v12) on the Location details, crash details, and EMS details pages as well

I wasn't sure about keeping the dark basemap, but I am convinced now that it's the way to go. So yeah, what you said!

Edit: ah, i see i left out the list pages from the scope. I think we should get ride of the light basemap everywhere 👍

okay i went ahead and updated the light mode streets basemap to use the colorful one for all maps 💯

roseeichelmann · 2025-10-31T17:28:52Z

editor/utils/formatters.ts

+  if (!value || typeof value !== "string") {
+    return "";
+  }
+  return format(parseISO(value), "MM/dd/yyyy h:mm a — E") || "";


is this marys preferred formatting with the slashes //'s ? it strays from our other date formatting and i remember once xavier talking about streamlining all or date formatting more

Yes, it is. Thanks for flagging it. We have at least 3 different ways of formatting date + time in the app right now. I'd like to get down to just one standard way before we ship this. I'll scope that!

johnclary

This looks great, Rose! I guess I'll hold my approval if you're going to replace the light maps from the list views.

johnclary · 2025-10-31T18:23:07Z

editor/app/fatalities/[record_locator]/page.tsx

+                        : "TxDOT"}
+                    </td>
+                  </tr>
+                </tbody>


This looks good to me. If we need to repeat this pattern again, I think we should extract a DataCardBody component from the DataCard component and drop that in as a replacement.

johnclary · 2025-10-31T18:24:05Z

editor/utils/formatters.ts

+  if (!value || typeof value !== "string") {
+    return "";
+  }
+  return format(parseISO(value), "MM/dd/yyyy h:mm a — E") || "";


Yes, it is. Thanks for flagging it. We have at least 3 different ways of formatting date + time in the app right now. I'd like to get down to just one standard way before we ship this. I'll scope that!

… streets

chiaberry

Its coming together! I like the colorful basemap

…pe involved

mddilley

Love seeing this view getting built out! I flagged one issue with the roadway owner field, but this all looks great. The basemap update looks ✨! 🎨

mddilley · 2025-11-10T23:03:03Z

editor/app/fatalities/[record_locator]/page.tsx

+                      Roadway owner
+                    </td>
+                    <td>
+                      {crash.is_coa_roadway === true


@roseeichelmann I couldn't find a crash that showed City of Austin, and I think it is because it is missing from the query and response (and maybe permissions?). Code to handle looks great!

good catch Mike!

thank you for catching this!! usually there is an error when you try to access a property that doesnt exist... i wonder why that didnt happen? is it bc the type for Crash.is_coa_roadway is boolean OR null?

…field Add units types involved view

frankhereford

This looks great Rose, thank you! I think your change of using the colorful map in light mode across the board is a big level up - looks fantastic!

mddilley

Retested with the latest update, and I can the corresponding roadway owners when looking at on- or off-system records. 🚢 😎

chiaberry

looks good! ✅

mateoclarke

👍

roseeichelmann added 9 commits October 8, 2025 16:24

add 404 page, handle no data, add rows and cols for card

2f85884

add datacards column config

a75555f

new date formatter

ed79bd7

Add datacard

76b1cc1

add crash map

500d76b

udate to add a footer component

8bbdfa1

fix typo

d806b8b

add this new component

2d1058e

formatting

1a6363c

roseeichelmann added the WIP Work in progress label Oct 29, 2025

roseeichelmann changed the base branch from main to rose/create_fatality_page_24771 October 29, 2025 19:25

roseeichelmann added 11 commits October 30, 2025 14:18

completely custom component w fields and map

8847eab

delete this

395a193

remove this stuff, not gonna go this route after all

b526863

add coa roadway to crash type

2102e66

delete these files

b1dc7be

Merge branch 'rose/create_fatality_page_24771' into rose/fatality_pag…

6e66211

…e_summary_24972

Merge branch 'rose/create_fatality_page_24771' into rose/fatality_pag…

8dabde8

…e_summary_24972

edit useBasemap to use color streets conditionally

81ac067

add color streets to mapStyleOptions

adb15ee

add color streets to all the maps that need it

44a513c

sort imports

4efba44

roseeichelmann commented Oct 31, 2025

View reviewed changes

fix comment

baa30ad

roseeichelmann commented Oct 31, 2025

View reviewed changes

johnclary reviewed Oct 31, 2025

View reviewed changes

johnclary added 3 commits October 31, 2025 14:41

create units_involved_view

5ecd0f4

add units_involved_view to api metadata

1972413

add relationships

222f1f9

johnclary added 2 commits October 31, 2025 15:05

rename the view and column

6974a6a

fix is_deleted condition

824f5c4

roseeichelmann removed the WIP Work in progress label Nov 3, 2025

remove the useColorstreets prop and make all light mode use the color…

735d907

… streets

roseeichelmann requested review from chiaberry, frankhereford, johnclary, mateoclarke, mddilley and tillyw November 3, 2025 19:02

chiaberry approved these changes Nov 5, 2025

View reviewed changes

johnclary added 3 commits November 7, 2025 12:48

add 'single' prefix and use car/car etc when multiple of same unit ty…

8c8e45a

…pe involved

handle unkown body style

4977454

handle a few more unknown/other cases

e009394

mddilley reviewed Nov 10, 2025

View reviewed changes

Merge pull request #1886 from cityofaustin/john/24769-units-involved-…

c60ceaa

…field Add units types involved view

frankhereford approved these changes Nov 21, 2025

View reviewed changes

chiaberry self-requested a review November 24, 2025 21:16

add is_coa_roadway to query and permissions

bc560f6

roseeichelmann requested a review from mddilley November 24, 2025 22:57

mddilley approved these changes Nov 24, 2025

View reviewed changes

chiaberry approved these changes Nov 25, 2025

View reviewed changes

mateoclarke approved these changes Dec 13, 2025

View reviewed changes

johnclary approved these changes Jan 6, 2026

View reviewed changes

Fatality details page: Create summary/map card #1880

Are you sure you want to change the base?

Fatality details page: Create summary/map card #1880

Uh oh!

Conversation

roseeichelmann commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Associated issues

Testing

Ship list

Uh oh!

netlify bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Deploy Preview for atd-vze-staging failed. Why did it fail? →

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roseeichelmann Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnclary left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chiaberry left a comment

Choose a reason for hiding this comment

Uh oh!

mddilley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frankhereford left a comment

Choose a reason for hiding this comment

Uh oh!

mddilley left a comment

Choose a reason for hiding this comment

Uh oh!

chiaberry left a comment

Choose a reason for hiding this comment

Uh oh!

mateoclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

roseeichelmann commented Oct 29, 2025 •

edited

Loading

netlify bot commented Oct 29, 2025 •

edited

Loading

johnclary Oct 31, 2025 •

edited

Loading

roseeichelmann Nov 3, 2025 •

edited

Loading