change negate of Num Bit from complement## to id
#3000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrDurion Could you add a changelog entry? thanks! |
martijnbastiaan
added a commit
to MrDurion/clash-compiler
that referenced
this pull request
Sep 20, 2025
martijnbastiaan
force-pushed
the
patch-1
branch
from
d913fd7 to
1f31ba9
Compare
martijnbastiaan
approved these changes
Sep 20, 2025
martijnbastiaan
force-pushed
the
patch-1
branch
from
1f31ba9 to
63ae22e
Compare
lmbollen
approved these changes
Sep 22, 2025
Comment on lines
41
to
44
| , testAdditiveInverse "Index 1" (genIndex @1) | ||
| -- TODO: | ||
| -- , testAdditiveInverse "Index 2" (genIndex @2) | ||
| -- , testAdditiveInverse "Index 128" (genIndex @128) |
There was a problem hiding this comment.
The additive inverse, and thus negate, is not defined for Index because the definition requires closure, which Index does not have for addition (maxBound + 1 => errorX). So you can remove these tests (and perhaps we should give thought to removing negate for Index)
There was a problem hiding this comment.
Agreed, could you add your thoughts under #3015?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects an error where the
negateof theNum Bitinstance used the complement instead of the identity function.The negate is the additive inverse, and for xor as the addition operator, the inverse should be the identity, not the complement.
Fixes: #2999
Still TODO: