Memory Space Mock GPU Unit Tests #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add tests for Mock GPU memory space reading where we test the "memory read --space <space>" command and also test using the public API changes.
| @@ -0,0 +1,3 @@ | |||
| C_SOURCES := main.c | |||
|
|
|||
| include Makefile.rules No newline at end of file | |||
There was a problem hiding this comment.
add this missing new line. You can configure VSCode to add new lines at the end of files automatically :)
lldb/test/API/lit.site.cfg.py.in
Outdated
|
|
||
| # GPU Plugins | ||
| lldb_enable_mock_gpu_plugin = '@LLDB_ENABLE_MOCK_GPU_PLUGIN@' | ||
| if lldb_enable_mock_gpu_plugin == 'ON' or lldb_enable_mock_gpu_plugin == '1': |
There was a problem hiding this comment.
you should instead use
if lldb_enable_mock_gpu_plugin in ('ON', '1'):
you can change the amdgpu line below as well
walter-erquinigo
approved these changes
Sep 3, 2025
clayborg
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for Mock GPU memory space reading where we test the "memory read --space " command and also test using the public API changes.