Fix/Feature: Valence Battery Update/Fix (#227) #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only add battery estimator when no battery driver * Update valence arguments * Fix valence launch filename * Remove duplicate definition * Add robot namespace argument
luis-camero
requested review from
roni-kreinin and
tonybaltovski
and removed request for
a team
🧪 CI InsightsHere's what we observed from your CI run for e310781. 🟢 All jobs passed!But CI Insights is watching 👀 |
tonybaltovski
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add battery estimator when no battery driver
Update valence arguments
Fix valence launch filename
Remove duplicate definition
Add robot namespace argument