TypeError when using Components\Actor in CreateActorTokenRequ… #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Made Components\Actor extend Operations\Actor.
This way, both classes work in the constructor without breaking compatibility.
Validation
php -r 'require "vendor/autoload.php"; $a=new \Clerk\Backend\Models\Components\Actor(); $a->sub="user_123"; $b=new \Clerk\Backend\Models\Operations\CreateActorTokenRequestBody("user_123",$a); echo json_encode($b);'Output after fix:
{"userId":"user_123","actor":{"sub":"user_123","additionalProperties":null},"expiresInSeconds":3600,"sessionMaxDurationInSeconds":1800}The bug only occurs if a developer imports Components\Actor instead of Operations\Actor. However, since both classes exist with the same name, it’s easy to make this mistake even for experienced developers (autocomplete/IDE often suggests Components fo example). The result is a fatal runtime error, this PR eliminates that pitfall with a minimal and backwards-compatible change.