Fixed the react router issue and added a new test app to test for it #3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdt
approved these changes
Oct 17, 2025
JulienLavocat
approved these changes
Oct 17, 2025
|
Hey! I just made issue #3431 and hit this issue myself. I was wanting to share that I think your code will fix it as long as the table hook runs after isActive is set to true. cause it doesn't seem like the useSpacetimeDB hook causes updates. |
bfops
added
release-any
bfops
reviewed
Oct 20, 2025
crates/bindings-typescript/test-react-router-app/server/Cargo.toml
Outdated
Show resolved
Hide resolved
bfops
added a commit
that referenced
this pull request
Oct 27, 2025
…st app to test for it (#3428) This PR fixes #3359. Additionally I have add a new test app to test for this issue and I changed a perl script to be portable on windows. The issue was that `useTable` had it's own `isActive` state that it was incorrectly maintaining, when it should just have been using the connections `isActive` state directly. This fixes a critical bug and should be pushed ASAP. None, fixes a critical bug. 2, quite straightforward fix after figuring it out. - [x] I added a test app and tested the fix in my browser. --------- Co-authored-by: Zeke Foppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR fixes #3359. Additionally I have add a new test app to test for this issue and I changed a perl script to be portable on windows.
The issue was that
useTablehad it's ownisActivestate that it was incorrectly maintaining, when it should just have been using the connectionsisActivestate directly.This fixes a critical bug and should be pushed ASAP.
API and ABI breaking changes
None, fixes a critical bug.
Expected complexity level and risk
2, quite straightforward fix after figuring it out.
Testing