feat: update pgwire to 0.34 and improve how we disable ssl #3432
+11
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for opening this! We'll work on getting it reviewed. |
Merged
via the queue into
clockworklabs:master
with commit Oct 21, 2025
d205795
18 of 20 checks passed
bfops
pushed a commit
that referenced
this pull request
Oct 22, 2025
…ow we disable ssl (#3432) # Description of Changes Hello team, I'm the original author of pgwire library. In this patch, I have some updates about spacetimedb's usage of pgwire library: - Updated pgwire library to 0.34, which includes a critical fix for busy loop on accepting new connection - This version will return error on no-op handlers, as requested by @mamcx - Update `StartupHandler` for `SslRequest`. `SslRequest` is handled in `process_socket` automatically before `StartupHandler` kicks in. So it's safe to remove the match branch. The framework will reject TLS negotiation automatically if no TLS support compiled - Updated feature flags. Add `no-default-features` so we will not pull TLS dependencies. # API and ABI breaking changes N/A # Expected complexity level and risk 1 # Testing Would be nice to verify if you have integration test on postgres interface. --------- Co-authored-by: Mario Montoya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Hello team, I'm the original author of pgwire library. In this patch, I have some updates about spacetimedb's usage of pgwire library:
StartupHandlerforSslRequest.SslRequestis handled inprocess_socketautomatically beforeStartupHandlerkicks in. So it's safe to remove the match branch. The framework will reject TLS negotiation automatically if no TLS support compiledno-default-featuresso we will not pull TLS dependencies.API and ABI breaking changes
N/A
Expected complexity level and risk
1
Testing
Would be nice to verify if you have integration test on postgres interface.