-
Notifications
You must be signed in to change notification settings - Fork 639
CI - Move Internal Tests
to GitHub
#3436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+107
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
commented
Oct 20, 2025
bfops
commented
Oct 21, 2025
jdetter
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine as well, I just had one quick testing Q on this one and then a request before merging. I have not tested this myself but the changes make sense and the CI is passing. Thanks for this @bfops 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no runtime change
This change does not affect the final binaries
release-any
To be landed in any release window
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Move a version of the Jenkins logic into a GitHub workflow. See the linked issue for more context.
API and ABI breaking changes
None. CI only.
Expected complexity level and risk
2
Testing