Skip to content

Conversation

@kgritesh
Copy link

Fixes #21

Copy link
Contributor

@alanhamlett alanhamlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@xuru
Copy link

xuru commented Dec 18, 2017

FYI, this doesn't use the custom encoder/decoder in gen_unique_id which I ran into using this code.

@kgritesh
Copy link
Author

@alanhamlett @xuru let me know if we need to use this custom serialiser in get_unique_id function. Also let me know if anything pending for this to be merged?

@xuru
Copy link

xuru commented Dec 30, 2017

@kgritesh I took a different approach then passing in a call back for serialization/deserialization. I decided to do it like flask does it, and pass in the json encoder/decoder in order to serialize custom types. I created a pull request: #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants