[ui-importer-modal] Bulk Edit column modal second iteration #4165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananya-agarwal
requested review from
JohanAhlen,
bjornalm,
Copilot,
ramprasadagarwal and
tabraiz12
|
✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅ |
UI Code Coverage Report
|
Backend Code Coverage Report •
|
tabraiz12
reviewed
Jun 10, 2025
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
tabraiz12
reviewed
Jun 10, 2025
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
ramprasadagarwal
requested changes
Jun 10, 2025
Collaborator
ramprasadagarwal
left a comment
ramprasadagarwal
left a comment
There was a problem hiding this comment.
Nice work! See comments below
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
Can we get some screenshots for this PR? |
tabraiz12
reviewed
Jun 12, 2025
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
tabraiz12
reviewed
Jun 19, 2025
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...p/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.scss
Outdated
Show resolved
Hide resolved
...p/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.scss
Outdated
Show resolved
Hide resolved
tabraiz12
reviewed
Jun 19, 2025
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
tabraiz12
reviewed
Jun 23, 2025
...re/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.test.tsx
Outdated
Show resolved
Hide resolved
ramprasadagarwal
requested changes
Jun 23, 2025
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
...op/core/src/desktop/js/apps/newimporter/ImporterFilePreview/EditColumns/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
bjornalm
approved these changes
Sep 19, 2025
Collaborator
bjornalm
left a comment
bjornalm
left a comment
There was a problem hiding this comment.
Approved,
and thanks for the video.
...op/core/src/desktop/js/apps/newimporter/FilePreviewTab/EditColumnsModal/EditColumnsModal.tsx
Outdated
Show resolved
Hide resolved
tabraiz12
approved these changes
Sep 19, 2025
ananya-agarwal
force-pushed
the
modal
branch
from
2447cbb to
b66aeb7
Compare
ananya-agarwal
force-pushed
the
modal
branch
from
cc869e1 to
07e0b15
Compare
ananya-agarwal
requested review from
Harshg999 and
ramprasadagarwal
and removed request for
Harshg999,
JohanAhlen and
ramprasadagarwal
bjornalm
approved these changes
Sep 19, 2025
tabraiz12
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding edit columns button on the right and on clicking it, getting the modal with 4 different columns, a cancel and a done button, where the user will be able to edit the column header from the modal and on clicking Done button, he/she will be able to see the updated column header (name) in the preview. Also, getting pre-filled data from the file (say csv) into the modal.
How was this patch tested?
Manual testing, will add unit tests soon.
Video of what is done in the PR:
Screen.Recording.2025-07-14.at.3.14.38.PM.mov
Please review Hue Contributing Guide before opening a pull request.