Skip to content

[ui-core] fix: clears FileUploadQueue when user closes the Queue dialog #4228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 25, 2025
Merged

[ui-core] fix: clears FileUploadQueue when user closes the Queue dialog #4228

merged 9 commits into from
Sep 25, 2025

Conversation

@ramprasadagarwal
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal commented Aug 19, 2025 •
edited
Loading

What changes were proposed in this pull request?

  • Previously, when the user clicked the close icon on the file upload drawer, the drawer would close, but the uploaded file list was not cleared. As a result, upon uploading new files, the user would see both the newly uploaded files and the previously retained ones. This PR addresses and resolves that issue by ensuring the file list is cleared when the drawer is closed.
  • Added a button to cancel all pending files.
  • Showing the Upload drawer only on the storage browser page.
Screen.Recording.2025-09-24.at.6.47.33.PM.mov

How was this patch tested?

  • Added unit tests

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this Aug 19, 2025
@github-actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅

@github-actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

UI Code Coverage Report

Lines Statements Branches Functions
Coverage: 33%
 39.88% (31295/78465) 31.55% (14604/46277) 25.79% (2346/9094)

@github-actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

Coverage

Backend Code Coverage Report •
FileStmtsMissCoverMissing
TOTAL567532875749% 
report-only-changed-files is enabled. No files were changed during this commit :)

sanyam43
sanyam43 previously approved these changes Aug 20, 2025
View reviewed changes
bjornalm
bjornalm approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) September 25, 2025 08:35
JohanAhlen
JohanAhlen approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramprasadagarwal ramprasadagarwal merged commit b5577aa into master Sep 25, 2025
9 checks passed
@ramprasadagarwal ramprasadagarwal deleted the fix/upload-queue branch September 25, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@bjornalm bjornalm bjornalm approved these changes

@sanyam43 sanyam43 sanyam43 left review comments

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

Assignees

@ramprasadagarwal ramprasadagarwal

Labels

ai-generated-code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ramprasadagarwal @JohanAhlen @bjornalm @sanyam43