Skip to content

[ui-core] chore: replace fetchOptions with options in useLoadData #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 16, 2025
Merged

[ui-core] chore: replace fetchOptions with options in useLoadData #4231

merged 9 commits into from
Sep 16, 2025

Conversation

@ramprasadagarwal
Copy link
Collaborator

@ramprasadagarwal ramprasadagarwal commented Aug 20, 2025 •
edited
Loading

What changes were proposed in this pull request?

  • replaces fetchOptions with options.

How was this patch tested?

  • Manually tested

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this Aug 20, 2025
@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

⚠️ No test files modified. Please ensure that changes are properly tested. ⚠️

@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

UI Code Coverage Report

Lines Statements Branches Functions
Coverage: 33%
 39.79% (31182/78358) 31.47% (14541/46205) 25.45% (2306/9059)

@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

Coverage

Backend Code Coverage Report •
FileStmtsMissCoverMissing
TOTAL567522875649% 
report-only-changed-files is enabled. No files were changed during this commit :)

@ramprasadagarwal ramprasadagarwal changed the title [ui-core] feat: encode query params in GET API calls [ui-core] chore: replace qsEncodeData with encodeData Sep 15, 2025
@ramprasadagarwal ramprasadagarwal marked this pull request as ready for review September 16, 2025 10:14
@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) September 16, 2025 10:15
@ramprasadagarwal ramprasadagarwal changed the title [ui-core] chore: replace qsEncodeData with encodeData [ui-core] chore: replace fetchOptions with options in useLoadData Sep 16, 2025
bjornalm
bjornalm approved these changes Sep 16, 2025
View reviewed changes
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramprasadagarwal ramprasadagarwal merged commit 85b8202 into master Sep 16, 2025
9 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/use-load-data branch September 16, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornalm bjornalm bjornalm approved these changes

@nidhibhatg nidhibhatg nidhibhatg approved these changes

Assignees

@ramprasadagarwal ramprasadagarwal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ramprasadagarwal @bjornalm @nidhibhatg