Skip to content

fix: cloudflare_workers_script run_worker_first accepts list input #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maxwellpeterson wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: cloudflare_workers_script run_worker_first accepts list input #6178

maxwellpeterson wants to merge 1 commit into from

Conversation

@maxwellpeterson
Copy link
Member

@maxwellpeterson maxwellpeterson commented Sep 15, 2025

  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

  • Update assets.config.run_worker_first property of cloudflare_workers_script resource to accept list of strings in addition to boolean input
  • The Cloudflare API accepts both types of values, so this resource should support both

Additional context & links

Fixes #5956

aashishshrestha09
aashishshrestha09 reviewed Sep 15, 2025
View reviewed changes
Copy link

@aashishshrestha09 aashishshrestha09 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxwellpeterson,

Thanks for the PR! I wanted to flag that there still seems to be an issue with the config property inside assets. When using a config block, the provider fails with a conversion error (see my comment here
).

It would be great if this PR could take that scenario into account to ensure the provider correctly handles the config block with both boolean and list values.

Thanks!

1000hz
1000hz reviewed Sep 15, 2025
View reviewed changes
1000hz
1000hz reviewed Sep 15, 2025
View reviewed changes
@1000hz
Copy link
Contributor

1000hz commented Sep 15, 2025

@aashishshrestha09 the bug you ran into was due to a mismatch between the attribute type within the model and schema. Sorry for the trouble here. This PR handles both boolean and string[] cases by using a Dynamic attribute capable of accepting both types.

@aashishshrestha09
Copy link

aashishshrestha09 commented Sep 15, 2025

@aashishshrestha09 the bug you ran into was due to a mismatch between the attribute type within the model and schema. Sorry for the trouble here. This PR handles both boolean and string[] cases by using a Dynamic attribute capable of accepting both types.

Hi @1000hz,

Thank you for clarifying! That makes sense. Once this PR is merged, will the fix be available immediately in a v5.10.1 patch release, or will we need to wait for the next provider release (v5.11.0) to use it in Terraform?

Thanks again! Also, I’ve detected another issue with the assets block and have created a bug report here.

@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from c515531 to c2860d8 Compare September 16, 2025 17:24
@maxwellpeterson maxwellpeterson marked this pull request as ready for review September 16, 2025 17:24
@vaishakdinesh
Copy link
Member

vaishakdinesh commented Sep 16, 2025 •
edited
Loading

Can you target next please? And make sure its branched off next too.

@1000hz 1000hz mentioned this pull request Sep 16, 2025
Merged
1 task
@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from 7cf72a8 to 82c4243 Compare September 17, 2025 00:02
@maxwellpeterson maxwellpeterson changed the base branch from main to next September 17, 2025 00:02
@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch 2 times, most recently from d749e65 to 13945ad Compare September 23, 2025 19:30
@stainless-app stainless-app bot force-pushed the next branch 2 times, most recently from 49bbfc7 to 618db3c Compare October 2, 2025 09:32
@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch 4 times, most recently from 795436c to d7029b1 Compare October 6, 2025 21:37
@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch 6 times, most recently from 0307d26 to 703136b Compare October 7, 2025 22:47
@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from 703136b to e559756 Compare October 8, 2025 16:49
vaishakdinesh
vaishakdinesh reviewed Oct 10, 2025
View reviewed changes
@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from e559756 to 3c91e52 Compare October 15, 2025 17:25
@maxwellpeterson
fix: cloudflare_workers_script.assets.config.run_worker_first accepts…
b3fa633 
… list input

- This property can either be a boolean or list of strings, the API accepts both
- Update resource to accept list of strings in addition to boolean values
@maxwellpeterson maxwellpeterson force-pushed the mpeterson/run-worker-first-list branch from 3c91e52 to b3fa633 Compare October 17, 2025 19:56
@vaishakdinesh
Copy link
Member

vaishakdinesh commented Nov 20, 2025

lgtm

@musa-cf musa-cf force-pushed the next branch 2 times, most recently from 8419486 to d301974 Compare November 20, 2025 09:59
@vaishakdinesh
Copy link
Member

vaishakdinesh commented Dec 5, 2025

@maxwellpeterson Do we still need this? I think these changes are already in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaishakdinesh vaishakdinesh vaishakdinesh approved these changes

@mgirouard mgirouard Awaiting requested review from mgirouard

@tamas-jozsa tamas-jozsa Awaiting requested review from tamas-jozsa

@musa-cf musa-cf Awaiting requested review from musa-cf

@SirCortly SirCortly Awaiting requested review from SirCortly

@ssicard ssicard Awaiting requested review from ssicard

@rotem-cloud rotem-cloud Awaiting requested review from rotem-cloud

+2 more reviewers

@aashishshrestha09 aashishshrestha09 aashishshrestha09 left review comments

@1000hz 1000hz 1000hz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maxwellpeterson maxwellpeterson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

run_worker_fisrt does not support list input

4 participants

@maxwellpeterson @1000hz @aashishshrestha09 @vaishakdinesh