Skip to content

[Sealights][SLDEV-22556] - support instrumentation of defined npm script #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

CubikNeRubik
Copy link
Contributor

@CubikNeRubik CubikNeRubik commented Jul 25, 2025

  • A short explanation of the proposed change:

Extend the Sealights integration to support injection into any npm script command, not just npm start. This will enable support for commands like npm run start-dev, npm run dev, npm run server, etc.

  • An explanation of the use cases your change solves

It will be possible to define run command for injection as npmRunScript parameter

VCAP_SERVICES
{
  "user-provided": [{
    "name": "sealights-service",
    "credentials": {
      "token": "xxx",
      "buildSessionId": "xxx",
      "npmRunScript": "start-dev"
    }
  }]
}

If it is not provided Sealight will be injected into start command for backward compatibility.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have added an integration test

@marcam-sl
Copy link

Hi @arjun024 and @robdimsdale, just checking in on our pending PR. Could you (or someone from your team) share the expected review timeline? Please let us know if any changes are needed — we’re aiming for this enhancement to be part of the next nodejs-buildpack release (post v1.8.39). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants