Skip to content

Conversation

jogo
Copy link

@jogo jogo commented Feb 14, 2018

Newer versions of jingo and django-nose no longer work with older
versions of Django, so pin to get tests passing again.

jogo added 2 commits February 14, 2018 10:53
Stop writing directly to a users homedir, so we don't leave random files
lying around if the user deletes the repo. Instead use the default .tox
location.
Newer versions of jingo and django-nose no longer work with older
versions of Django, so pin to get tests passing again.
@jogo jogo changed the title Update dependencies to get tests running again Update dependencies to get tests running again and drop python2.6 support Feb 14, 2018
@jogo
Copy link
Author

jogo commented Feb 14, 2018

This is the first step in adding python3 support.

jogo added 2 commits February 14, 2018 12:32
Python2.6 is unsupported by all major distros. And Django stopped
supporting it in  Django 1.6.
@jogo jogo force-pushed the tests branch 2 times, most recently from 875c0cd to f1dee44 Compare February 14, 2018 21:03
In the travis env getting the following error:

...
  File "/home/travis/build/clouserw/tower/tower/tests/test_l10n.py", line 35, in setup
    tower.activate('xx')
  File "/home/travis/build/clouserw/tower/tower/__init__.py", line 104, in activate
    django_trans._active.value = _activate(locale)
  File "/home/travis/build/clouserw/tower/tower/__init__.py", line 130, in _activate
    t.set_language(locale)
AttributeError: NullTranslations instance has no attribute 'set_language'

This appears to related to https://code.djangoproject.com/ticket/18192
@jogo jogo changed the title Update dependencies to get tests running again and drop python2.6 support Update dependencies. drop python2.6 support, and add django 1.7 and 1.8 support Feb 15, 2018
* Use Jingo 0.8 for Django 1.8
* As of django/django@a5f6cbc
  DjangoTranslation object won't work when passed into gettext.translation. So
  use default gettext.GNUTranslations just like Django
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant