Remove ringcentral/psr7 because it appears to be abandoned and upstream projects would like to support psr/http-message ^2.0 #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am projects would like to support psr/http-message ^2.0
kwhat
force-pushed
the
remove_ringcentral_dep
branch
from
d5a3986 to
c8c42e8
Compare
|
Hey @clue, @WyriHaximus, could you take a look at this? I think this might be a solid direction/solution |
WyriHaximus
approved these changes
Jun 23, 2025
|
@CodeWithKyrian @kwhat This looks great to me as it doesn't introduce another dependency and it helps move reactphp/http#542 forward. But I don't have any power or say over this repo, so this is all in @clue's hands. |
This was referenced Jun 23, 2025
|
I understand. We wait then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear if we need to wait for all of the headers before parsing or if by removing the PSR7 requirement we can simply just parse the first line of the http response. I left the
strpos()in there in case there was a reason the code was waiting.This resolves issue #64