Skip to content

Conversation

clin1234
Copy link

No description provided.

@DRSDavidSoft
Copy link
Contributor

Thanks for the PR.

I believe I originally didn't added per monitor setup because we also need to handle DPI changes in the C++ code, it's not just a case for the manifest.

However, since we're not doing any GUI work in our launcher (it is just purely used to launch the actual terminal emulator, which is ConEmu is this case), and we're only using Windows' own dialogs, then I assume this change would be safe.

I need to investigate before merging to see wether the Dialogs and TaskDialogs that our code generates would truly support multiple monitor DPI scaling, by resizing automatically according to the monitor's DPI, and not preserving the DPI of the initial monitor (and thus keeping the size and not scaling correctly).

Thanks for the contribution! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants