Add support for (Linux) net device injection. #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/linux-net-device
branch
3 times, most recently
from
658b35b to
9900940
Compare
elezar
reviewed
Apr 9, 2025
elezar
reviewed
Apr 9, 2025
elezar
reviewed
Apr 9, 2025
pkg/cdi/container-edits.go
Outdated
| // specgen is currently missing functionality to set Linux NetDevices, | ||
| // so we use a locally rolled function for now. | ||
| for _, dev := range e.NetDevices { | ||
| specgenAddLinuxNetDevice(&specgen, dev.HostIf, &oci.LinuxNetDevice{ |
There was a problem hiding this comment.
Is this something we want to contribute to specgen?
There was a problem hiding this comment.
Yes, I am planning to do it once the necessary runtime-spec bits get tagged.
elezar
reviewed
Apr 9, 2025
elezar
reviewed
Apr 9, 2025
Signed-off-by: Krisztian Litkey <[email protected]>
Implement OCI Spec (Linux) NetDevice injection. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/linux-net-device
branch
from
9900940 to
e95cee0
Compare
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for injecting recently introduced (Linux) NetDevices to OCI Specs. Once all the necessary bits are merged and make their way to the runtimes, merging this should allow injection of (Linux) NetDevices over CRI without any changes to the protocol.
Notes:
This PR is marked a draft since it uses an untagged opencontainers/runtime-spec version v1.2.2-0.20250401095657-e935f995dd67. Once a new version is tagged, we can mark this PR ready for review.