Fix inverse token mask concatenation error and add support for mps devices #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer Python versions does not allow direct concatenation between typing.List and None. The implementation has been corrected by setting `inverse_token_mask` in `_preprocess_sentence` from `None` to `[]`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your great work and generous contribution. During my reimplementation of your work I have noticed the following error:
in
/bert/dataset.py, at line 197 in method_preprocess_sentence(), the default value ofinverse_token_maskhas been set toNone, which cannot be directly appended to aListobject. With Python 3.11, running the code will result in the following error:which can be resolved by replacing the variable's default value as an empty list
[].Having noticed you haven't enabled mps device acceleration support for Apple Silicon devices, I have added support for it as well. It will make full use of Apple Silicon SoCs' GPU for model training and should yields much faster model training speed.