Skip to content

storage: add cluster setting to use old compaction eligibility #152356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

storage: add cluster setting to use old compaction eligibility #152356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions pkg/storage/pebble.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,22 @@ var enableMultiLevelWriteAmpHeuristic = settings.RegisterBoolSetting(
true,
)

// useDeprecatedCompensatedScore is a temporary setting that provides a
// mechanism for reverting Pebble's compaction picking heuristic to the previous
// (25.3 and earlier) behavior for deciding when a level is eligible for
// compaction. See the pebble.Options Experimental UseDeprecatedCompensatedScore
// setting for details.
//
// We anticipate not needing to use this setting, but it's provided as an escape
// hatch in case the heuristic change has an unforeseen impact on some
// workloads.
var useDeprecatedCompensatedScore = settings.RegisterBoolSetting(
settings.ApplicationLevel,
"storage.use_deprecated_compensated_score",
"If enabled, this setting revert's the storage engine's compaction picking heuristic",
false,
)

// SSTableCompressionProfile is an enumeration of compression algorithms
// available for compressing SSTables (e.g. for backup or transport).
type SSTableCompressionProfile int64
Expand Down Expand Up @@ -894,6 +910,11 @@ func newPebble(ctx context.Context, cfg engineConfig) (p *Pebble, err error) {
return int(concurrentDownloadCompactions.Get(&cfg.settings.SV))
}
}
if cfg.opts.Experimental.UseDeprecatedCompensatedScore == nil {
cfg.opts.Experimental.UseDeprecatedCompensatedScore = func() bool {
return useDeprecatedCompensatedScore.Get(&cfg.settings.SV)
}
}

cfg.opts.EnsureDefaults()

Expand Down
Loading