Skip to content

Conversation

andyyang890
Copy link
Collaborator

This patch fixes a bug where the progress skew metrics could show
incorrect data because the computation previously relied on comparing
the fastest span/table timestamps with the checkpointed timestamp
(overall resolved timestamp) and these two pieces of information
weren't kept in sync.

Fixes #155083

Release note: None

This patch fixes a bug where the progress skew metrics could show
incorrect data because the computation previously relied on comparing
the fastest span/table timestamps with the checkpointed timestamp
(overall resolved timestamp) and these two pieces of information
weren't kept in sync.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 added the backport-25.4.x Flags PRs that need to be backported to 25.4 label Oct 10, 2025
@andyyang890 andyyang890 requested a review from log-head October 10, 2025 20:41
@andyyang890 andyyang890 marked this pull request as ready for review October 10, 2025 20:41
@andyyang890 andyyang890 requested a review from a team as a code owner October 10, 2025 20:41
Copy link
Contributor

@log-head log-head left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andyyang890 andyyang890 requested a review from asg0451 October 14, 2025 18:31
@andyyang890
Copy link
Collaborator Author

TFTRs!

bors r=log-head,asg0451

@craig
Copy link
Contributor

craig bot commented Oct 16, 2025

@craig craig bot merged commit 3c76919 into cockroachdb:master Oct 16, 2025
25 checks passed
@andyyang890 andyyang890 deleted the 20251008-fix-skew-metrics branch October 16, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-25.4.x Flags PRs that need to be backported to 25.4 target-release-26.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

changefeedccl: table skew metric can be non-zero when per-table tracking is off

4 participants