Skip to content

backfill: add a separate control for number of vectors merged per batch #155284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

backfill: add a separate control for number of vectors merged per batch #155284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion pkg/sql/backfill/mvcc_index_merger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,17 @@ var indexBackfillMergeBatchSize = settings.RegisterIntSetting(
settings.NonNegativeInt, /* validateFn */
)

// indexBackfillVectorMergeBatchSize is the maximum number of vectors we attempt to merge
// in a single transaction during the merging process. This is a much smaller number because
// fixups create a lot of conflicts with big batches.
var indexBackfillVectorMergeBatchSize = settings.RegisterIntSetting(
settings.ApplicationLevel,
"bulkio.index_backfill.vector_merge_batch_size",
"the number of vectors we merge between temporary and adding indexes in a single batch",
3,
settings.NonNegativeInt, /* validateFn */
)

// indexBackfillMergeBatchBytes is the maximum number of bytes we attempt to
// merge from the temporary index in a single transaction during the merging
// process.
Expand Down Expand Up @@ -315,7 +326,12 @@ func (ibm *IndexBackfillMerger) scan(
}
}
}
chunkSize := indexBackfillMergeBatchSize.Get(&ibm.flowCtx.Cfg.Settings.SV)
var chunkSize int64
if _, ok := ibm.VectorIndexes[ibm.spec.AddedIndexes[spanIdx]]; ok {
chunkSize = indexBackfillVectorMergeBatchSize.Get(&ibm.flowCtx.Cfg.Settings.SV)
} else {
chunkSize = indexBackfillMergeBatchSize.Get(&ibm.flowCtx.Cfg.Settings.SV)
}
chunkBytes := indexBackfillMergeBatchBytes.Get(&ibm.flowCtx.Cfg.Settings.SV)

var br *kvpb.BatchResponse
Expand Down