Skip to content

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Oct 10, 2025

Backport 1/1 commits from #152364.

/cc @cockroachdb/release


Before this change, when the change frontier encountered an error while
restoring a changefeed's span-level checkpoint, it would ignore the
error instead of moving to draining like change aggregators would.

Fixes #152104

Release note: None


Release justification: adding missing error handling which could allow data corruption to go unnoticed

@andyyang890 andyyang890 requested a review from asg0451 October 10, 2025 21:05
@andyyang890 andyyang890 requested a review from a team as a code owner October 10, 2025 21:05
Copy link

blathers-crl bot commented Oct 10, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cdc labels Oct 10, 2025
Copy link

blathers-crl bot commented Oct 10, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link

blathers-crl bot commented Oct 10, 2025

✅ PR #155288 is compliant with backport policy

Confidence: high
Critical bug criteria met: [Data corruption]
Backward compatible: true
Explanation: The changes made in this PR involve modifying error handling mechanisms to address a potential data corruption issue. Specifically, it deals with an error that was previously ignored during changefeed checkpoint restoration, which would allow data corruption to go unnoticed. Such a fix is critical as it falls under the category of addressing data corruption, which is listed in the critical bug criteria. The PR contains a 'Release justification' line that specifies this change adds missing error handling to prevent unnoticed data corruption. Since this fix is related to a critical issue, it does not require feature flag gating according to the policy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Before this change, when the change frontier encountered an error while
restoring a changefeed's span-level checkpoint, it would ignore the
error instead of moving to draining like change aggregators would.

Release note: None
@andyyang890 andyyang890 merged commit c75e10e into cockroachdb:release-25.2 Oct 16, 2025
16 checks passed
@andyyang890 andyyang890 deleted the backport25.2-152364 branch October 16, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-cdc target-release-25.2.8

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants