db: add TestCrashDuringOpenRandomized

[annrpom]

Fixes: #4342

[cockroach-teamcity]

This change is 

[jbowens]

@jbowens reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions

---

open_test.go line 2244 at r11 (raw file):

	for valid := iter.First(); valid; valid = iter.Next() {
		key := string(iter.Key())
		value := make([]byte, len(iter.Value()))

nit: could use slices.Clone(iter.Value())

---

open_test.go line 2251 at r11 (raw file):

	// Verify that found data matches expected data.
	require.True(t, len(foundKeys) > 0, "no keys found after crash")

nit: could use require.NotEmpty(t, foundKeys, "no keys found after crash") (so the printed message during a failure is a little more clear)

[annrpom]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jbowens)

---

open_test.go line 2244 at r11 (raw file):

Previously, jbowens (Jackson Owens) wrote…

nit: could use slices.Clone(iter.Value())

done

---

open_test.go line 2251 at r11 (raw file):

Previously, jbowens (Jackson Owens) wrote…

nit: could use require.NotEmpty(t, foundKeys, "no keys found after crash") (so the printed message during a failure is a little more clear)

done

[annrpom]

TFTR! ('-')7