Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Aug 8, 2025

This PR depends on:

This PR includes:

Suggested followup PR would be to implement Nx caching. This is partially started here: #1035.

Note

Potential changes arrive after #1058 is merged

Closes #1048

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 cli labels Aug 8, 2025
Copy link

github-actions bot commented Aug 8, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 4553888 with previous commit 49adbf3.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🔴 29 ↓ −2.8
Code coverage 🟢 90 🟢 90 ↓ −0.1
Security 🔴 0 🔴 0
Updates 🟡 77 🟡 77
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👎 2 groups regressed, 👍 1 audit improved, 👎 4 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🔴 29 ↓ −2.8
Code coverage Code coverage metrics 🟢 90 🟢 90 ↓ −0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 7.7 s 🟥 10.8 s ↑ +39.3 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.4 s ↑ +10.6 %
Code coverage Branch coverage 🟨 85 % 🟨 85 % ↓ −0.1 %
Code coverage Line coverage 🟨 86.8 % 🟨 86.8 % ↓ −0.1 %
Code coverage Function coverage 🟩 93.2 % 🟩 93.2 % ↑ +0.1 %
Lighthouse Minimizes main-thread work 🟥 16.5 s 🟥 22.0 s ↑ +32.8 %
Lighthouse Total Blocking Time 🟥 4,480 ms 🟥 6,960 ms ↑ +55.4 %
Lighthouse JavaScript execution time 🟥 7.9 s 🟥 9.4 s ↑ +19.9 %
Lighthouse Largest Contentful Paint 🟥 10.8 s 🟥 12.0 s ↑ +11.3 %
Lighthouse Time to Interactive 🟥 17.0 s 🟥 17.9 s ↑ +4.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +4.9 %
Lighthouse Initial server response time was short 🟥 Root document took 970 ms 🟥 Root document took 1,760 ms ↑ +81.1 %
Lighthouse Max Potential First Input Delay 🟥 1,270 ms 🟥 2,030 ms ↑ +60 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 99 KiB 🟥 Potential savings of 93 KiB ↓ −34.8 %
Lighthouse Server Backend Latencies 🟩 1,070 ms 🟩 920 ms ↓ −14 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,660 KiB 🟩 Total size was 2,660 KiB ↓ −0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 549 KiB 🟥 Potential savings of 549 KiB ↓ −2.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 102 KiB 🟥 Potential savings of 102 KiB ↓ −1.6 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 80 ms ↑ +13.8 %

590 other audits are unchanged.

Copy link

pkg-pr-new bot commented Aug 11, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1059

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1059

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1059

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1059

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1059

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1059

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1059

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1059

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1059

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1059

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1059

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1059

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1059

commit: 612dcb8

@BioPhoton BioPhoton marked this pull request as ready for review August 12, 2025 00:14
@BioPhoton BioPhoton requested a review from matejchalk August 12, 2025 00:14
…o-cli

# Conflicts:
#	e2e/cli-e2e/tests/collect.e2e.test.ts
#	packages/cli/src/lib/implementation/core-config.middleware.ts
#	packages/core/src/lib/collect-and-persist.ts
@BioPhoton BioPhoton requested a review from matejchalk August 12, 2025 12:15
@BioPhoton BioPhoton requested a review from matejchalk August 12, 2025 12:49
matejchalk
matejchalk previously approved these changes Aug 12, 2025
@BioPhoton BioPhoton merged commit 0aee085 into main Aug 12, 2025
17 checks passed
@BioPhoton BioPhoton deleted the add-caching-options-to-cli branch August 12, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 cli 🧩 core 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce secondary report format to enable caching of plugin results
2 participants