-
Notifications
You must be signed in to change notification settings - Fork 15
ci: invalidate test cache if dependencies change #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 9517233
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 62a60f2 with previous commit d1a115b. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 90 | 🟢 91 |
5 other categories are unchanged.
👍 1 group improved, 👍 1 audit improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 90 | 🟢 91 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟨 73.7 % | 🟨 75 % |
442 other audits are unchanged.
💼 Project nx-plugin
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 85 | 🟡 85 |
5 other categories are unchanged.
👍 1 group improved, 👍 1 audit improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 85 | 🟡 85 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟨 75.4 % | 🟨 76.4 % | |
| Code coverage | Line coverage | 🟨 79.3 % | 🟨 79.3 % |
445 other audits are unchanged.
12 other projects are unchanged.
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 62a60f2 with previous commit d1a115b. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👍 1 audit improved, 👎 5 audits regressed, 22 audits changed without impacting score🗃️ Groups
21 other groups are unchanged. 🛡️ Audits
650 other audits are unchanged. |
Should prevent problems like #1166. The
unit-testtarget forplugin-lighthouseused the remote cache, despite the fact that there were code changes inutilsthat should've invalidated the cache.Invalidating the cache uncovered a failing test in standalone job, which is caused by
tsxenvironment variables using a relative tsconfig path. I fixed it by creating an absolute path usinggithub.workspacefrom context.