Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Dec 4, 2025

Should prevent problems like #1166. The unit-test target for plugin-lighthouse used the remote cache, despite the fact that there were code changes in utils that should've invalidated the cache.


Invalidating the cache uncovered a failing test in standalone job, which is caused by tsx environment variables using a relative tsconfig path. I fixed it by creating an absolute path using github.workspace from context.

@nx-cloud
Copy link

nx-cloud bot commented Dec 4, 2025

View your CI Pipeline Execution ↗ for commit 9517233

Command Status Duration Result
nx affected -t e2e-test --parallel=1 ✅ Succeeded 11m 39s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-04 13:15:57 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 4, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1167

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1167

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1167

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1167

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1167

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1167

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1167

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1167

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1167

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1167

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1167

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1167

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1167

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1167

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1167

commit: 9517233

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 62a60f2 with previous commit d1a115b.

💼 Project create-cli

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 90 🟢 91 ↑ +0.4

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 90 🟢 91 ↑ +0.4

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 73.7 % 🟨 75 % ↑ +1.8 %

442 other audits are unchanged.

💼 Project nx-plugin

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 85 🟡 85 ↑ +0.3

5 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 85 🟡 85 ↑ +0.3

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 75.4 % 🟨 76.4 % ↑ +1.2 %
Code coverage Line coverage 🟨 79.3 % 🟨 79.3 % ↓ −0.1 %

445 other audits are unchanged.


12 other projects are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 62a60f2 with previous commit d1a115b.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 47 🔴 37 ↓ −10.1
Code coverage 🟡 89 🟡 89 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 100 🟢 100
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 35 🔴 35
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👎 2 groups regressed, 👍 1 audit improved, 👎 5 audits regressed, 22 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 47 🔴 37 ↓ −10.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

21 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 760 ms 🟩 Root document took 540 ms ↓ −28.9 %
Lighthouse Total Blocking Time 🟥 660 ms 🟥 1,420 ms ↑ +116.4 %
Lighthouse Speed Index 🟥 6.2 s 🟥 7.0 s ↑ +11.8 %
Lighthouse Max Potential First Input Delay 🟥 480 ms 🟥 1,470 ms ↑ +207.7 %
Lighthouse Time to Interactive 🟥 12.2 s 🟥 12.9 s ↑ +5.5 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.2 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 6.1 s 🟥 9.4 s ↑ +54.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,055 KiB 🟩 Total size was 2,052 KiB ↓ −0.1 %
Lighthouse JavaScript execution time 🟥 2.2 s 🟥 3.9 s ↑ +79.9 %
Lighthouse Largest Contentful Paint 🟥 11.0 s 🟥 11.9 s ↑ +8.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +5.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 32 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 1,470 ms 🟩 980 ms ↓ −33.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 185 KiB 🟥 Potential savings of 186 KiB ↓ −17.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↑ +33.3 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 98 KiB ↓ −25 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 20 ms ↓ −73.4 %
Lighthouse Avoids an excessive DOM size 🟥 2,366 elements 🟥 2,362 elements ↓ −0.2 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.2 s ↑ +0.1 %
Axe Accessibility Interactive controls must not be nested 🟩 61 elements 🟩 63 elements ↑ +3.3 %
TypeScript Semantic errors 🟥 2622 errors 🟥 2623 errors ↑ +0.1 %
Axe Accessibility Elements must only use supported ARIA attributes 🟩 100 elements 🟩 101 elements ↑ +1 %
Axe Accessibility ARIA attributes must be used as specified for the element's role 🟩 100 elements 🟩 101 elements ↑ +1 %
Axe Accessibility Elements must only use permitted ARIA attributes 🟩 100 elements 🟩 101 elements ↑ +1 %
Axe Accessibility ARIA attributes must conform to valid names 🟩 100 elements 🟩 101 elements ↑ +1 %
Axe Accessibility Buttons must have discernible text 🟩 14 elements 🟩 15 elements ↑ +7.1 %
Axe Accessibility Elements must have their visible text as part of their accessible name 🟥 2 errors 🟥 3 errors ↑ +50 %
Code coverage Line coverage 🟨 84.5 % 🟨 84.5 % ↓ −0.1 %

650 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review December 4, 2025 12:52
@matejchalk matejchalk merged commit a863abb into main Dec 4, 2025
36 of 37 checks passed
@matejchalk matejchalk deleted the fix-test-cache branch December 4, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants