-
Notifications
You must be signed in to change notification settings - Fork 15
fix(cli): respect CP_VERBOSE if --verbose argument not given #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit aa13bef
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
f19dcb6 to
03e7313
Compare
Code PushUp😟 Code PushUp report has regressed – compared current commit f927452 with previous commit e9544e0. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👎 2 groups regressed, 👎 6 audits regressed, 13 audits changed without impacting score🗃️ Groups
32 other groups are unchanged. 🛡️ Audits
659 other audits are unchanged. |
Code PushUp😟 Code PushUp report has regressed – compared current commit f927452 with previous commit e9544e0. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 93 | 🟢 93 |
5 other categories are unchanged.
👎 1 group regressed, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 93 | 🟢 93 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟨 84.6 % | 🟨 84.4 % | |
| Code coverage | Line coverage | 🟨 89.1 % | 🟨 89.1 % |
441 other audits are unchanged.
13 other projects are unchanged.
Fails when run in Nx Cloud on a commit which happens to have "--verbose" in the title (such as this one or parent). The verbose argument handling is already tested in executor.unit.test.ts, so it's not necessary to test such a non-critical feature again in E2E tests.
03e7313 to
aa13bef
Compare
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the fix!
When running
code-pushupwithout an explicit--verboseflag, debug logs weren't being printed despite theCP_VERBOSEenvironment variable being set. This was caused by the CLI option havingdefault: false, so there was no distinction between implicit and explicit verbosity.