Skip to content

Conversation

@matejchalk
Copy link
Collaborator

When running code-pushup without an explicit --verbose flag, debug logs weren't being printed despite the CP_VERBOSE environment variable being set. This was caused by the CLI option having default: false, so there was no distinction between implicit and explicit verbosity.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 cli labels Dec 10, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2025

View your CI Pipeline Execution ↗ for commit aa13bef

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 24s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 29s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-10 18:36:42 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1177

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1177

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1177

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1177

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1177

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1177

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1177

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1177

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1177

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1177

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1177

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1177

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1177

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1177

commit: aa13bef

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Code PushUp

😟 Code PushUp report has regressed – compared current commit f927452 with previous commit e9544e0.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 38 🔴 30 ↓ −7.9
Code coverage 🟡 89 🟡 89 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 100 🟢 100
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Documentation 🔴 35 🔴 35
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👎 2 groups regressed, 👎 6 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 38 🔴 30 ↓ −7.9
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

32 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟩 Root document took 480 ms 🟥 Root document took 750 ms ↑ +57.5 %
Lighthouse Speed Index 🟥 6.4 s 🟥 8.5 s ↑ +32.4 %
Lighthouse Total Blocking Time 🟥 1,350 ms 🟥 3,540 ms ↑ +161.6 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.6 s ↑ +10.1 %
Lighthouse Time to Interactive 🟥 13.0 s 🟥 13.8 s ↑ +6.4 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.1 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 9.5 s 🟥 14.7 s ↑ +55.3 %
Lighthouse JavaScript execution time 🟥 4.0 s 🟥 5.3 s ↑ +32 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 12.7 s ↑ +9.8 %
Lighthouse Max Potential First Input Delay 🟥 1,200 ms 🟥 2,040 ms ↑ +69.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +6.4 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,055 KiB 🟩 Total size was 2,055 KiB ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 187 KiB 🟥 Potential savings of 164 KiB ↓ −27.7 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↑ +66.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 90 KiB ↑ +36.4 %
Lighthouse Server Backend Latencies 🟩 1,290 ms 🟩 1,220 ms ↓ −5.7 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 20 ms ↓ −66 %
Code coverage Line coverage 🟨 84.8 % 🟨 84.8 % ↓ −0.1 %

659 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Code PushUp

😟 Code PushUp report has regressed – compared current commit f927452 with previous commit e9544e0.

💼 Project cli

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 93 🟢 93 ↓ −0.1

5 other categories are unchanged.

👎 1 group regressed, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 93 🟢 93 ↓ −0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 84.6 % 🟨 84.4 % ↓ −0.2 %
Code coverage Line coverage 🟨 89.1 % 🟨 89.1 % ↓ −0.1 %

441 other audits are unchanged.


13 other projects are unchanged.

Fails when run in Nx Cloud on a commit which happens to have
"--verbose" in the title (such as this one or parent).

The verbose argument handling is already tested in
executor.unit.test.ts, so it's not necessary to test such
a non-critical feature again in E2E tests.
@matejchalk matejchalk added the 🐛 bug something isn't working label Dec 10, 2025
@matejchalk matejchalk marked this pull request as ready for review December 10, 2025 18:54
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix!

@matejchalk matejchalk merged commit 9275fa5 into main Dec 10, 2025
24 checks passed
@matejchalk matejchalk deleted the fix-verbose-arg branch December 10, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug something isn't working 🧩 cli 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants