-
Notifications
You must be signed in to change notification settings - Fork 15
fix: ensure CLI bin directory is included in published package with executable permissions #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure CLI bin directory is included in published package with executable permissions #1183
Conversation
|
View your CI Pipeline Execution ↗ for commit a586dcd
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/js-packages-plugin
@code-pushup/eslint-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
dad6225 to
330ff7c
Compare
330ff7c to
17a0669
Compare
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the update! Looks good to me!
Maybe a comment in code to explain the why?
Code PushUp😟 Code PushUp report has regressed – compared current commit a86654b with previous commit a86654b. 🏷️ Categories👎 1 group regressed, 👎 5 audits regressed, 12 audits changed without impacting score🗃️ Groups
33 other groups are unchanged. 🛡️ Audits661 other audits are unchanged. |
Summary
bindirectory is properly included in the npm packagebin/index.jsindex.jsto./bin/index.jsin package.jsonThis fix addresses an issue where the CLI binary wasn't being included in the published npm package because the
filesfield in package.json only included thesrcdirectory. Without this fix, users installing the package via npm wouldn't get the executable bin file.Impact
code-pushupcommand will now work correctly after npm installTechnical Details
The fix involves:
bindirectory to the build assets inproject.jsonto ensure it's copied during buildpackage.jsonfromindex.jsto./bin/index.jsto match the actual file locationbin/index.jsfile is tracked in git with executable permissions (+x) to ensure they're preserved through version control and build processesThis follows a similar pattern to a previous fix (commit 0fd2eb4) that addressed executable permissions for the old location.