-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(plugin-lighthouse): rename category aggregation helper #1184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 04a2702
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 8e1ff75 with previous commit d107538. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 4 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
659 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 8e1ff75 with previous commit d107538. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🔴 47 | 🔴 48 | |
| Code coverage | 🟢 99 | 🟢 99 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDoc coverage | Documentation coverage | 🔴 47 | 🔴 48 | |
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDoc coverage | Variables coverage | 🟥 20 undocumented variables | 🟥 20 undocumented variables | |
| Code coverage | Line coverage | 🟩 97.2 % | 🟩 97 % | |
| Code coverage | Branch coverage | 🟩 96.1 % | 🟩 96.1 % |
440 other audits are unchanged.
13 other projects are unchanged.
matejchalk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The Axe plugin introduced
axeCategories(#1182) with a more intuitive naming convention that describes what you get rather than how it works internally. This PR aligns Lighthouse with the same pattern and fixes a bug discovered during the alignment work.createCategoriesreturning an empty array for single-URL configurationsmergeLighthouseCategoriestolighthouseCategoriesfor consistency with Axe plugin APImerge-categories.tstocategories.tsto align file structure