Skip to content

Conversation

@hanna-skryl
Copy link
Collaborator

The Axe plugin introduced axeCategories (#1182) with a more intuitive naming convention that describes what you get rather than how it works internally. This PR aligns Lighthouse with the same pattern and fixes a bug discovered during the alignment work.

  • Fix createCategories returning an empty array for single-URL configurations
  • Rename mergeLighthouseCategories to lighthouseCategories for consistency with Axe plugin API
  • Rename merge-categories.ts to categories.ts to align file structure
  • Rewrite category integration documentation to match the Axe plugin

@hanna-skryl hanna-skryl self-assigned this Dec 10, 2025
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 lighthouse-plugin labels Dec 10, 2025
@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2025

View your CI Pipeline Execution ↗ for commit 04a2702

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 25s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 12m 49s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-10 22:07:34 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1184

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1184

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1184

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1184

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1184

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1184

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1184

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1184

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1184

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1184

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1184

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1184

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1184

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1184

commit: 04a2702

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 8e1ff75 with previous commit d107538.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 34 🔴 39 ↑ +4.5
Documentation 🔴 35 🔴 35 ↑ +0.1
Code coverage 🟡 89 🟡 89 ↓ −0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 99 🟢 99
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 2 groups improved, 👎 1 group regressed, 👍 4 audits improved, 👎 3 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 34 🔴 39 ↑ +4.5
JSDoc coverage Documentation coverage 🔴 35 🔴 35 ↑ +0.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↓ −0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Total Blocking Time 🟥 2,020 ms 🟥 1,150 ms ↓ −42.8 %
Lighthouse First Contentful Paint 🟥 3.3 s 🟥 3.4 s ↑ +3.4 %
Lighthouse Time to Interactive 🟥 13.8 s 🟥 12.7 s ↓ −7.7 %
Lighthouse Speed Index 🟥 7.0 s 🟥 6.7 s ↓ −4.2 %
JSDoc coverage Variables coverage 🟥 253 undocumented variables 🟥 253 undocumented variables  +0 %
Code coverage Line coverage 🟨 84.8 % 🟨 84.8 % ↓ −0.1 %
Code coverage Branch coverage 🟨 87.1 % 🟨 87.1 % ↓ −0.1 %
Lighthouse Minimizes main-thread work 🟥 11.4 s 🟥 8.6 s ↓ −25 %
Lighthouse JavaScript execution time 🟥 5.4 s 🟥 3.4 s ↓ −36.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −7.7 %
Lighthouse Largest Contentful Paint 🟥 12.5 s 🟥 11.5 s ↓ −8.2 %
Lighthouse Max Potential First Input Delay 🟥 1,840 ms 🟥 1,000 ms ↓ −45.6 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,055 KiB 🟩 Total size was 2,055 KiB ↓ −0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 1,260 ms 🟩 1,660 ms ↑ +31.3 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↓ −24.6 %
Lighthouse Initial server response time was short 🟩 Root document took 570 ms 🟩 Root document took 600 ms ↑ +5.2 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 50 ms ↓ −21.5 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 186 KiB 🟥 Potential savings of 186 KiB ↑ +1.1 %

659 other audits are unchanged.

@github-actions
Copy link
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 8e1ff75 with previous commit d107538.

💼 Project plugin-lighthouse

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 47 🔴 48 ↑ +0.4
Code coverage 🟢 99 🟢 99 ↓ −0.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 1 audit improved, 👎 2 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDoc coverage Documentation coverage 🔴 47 🔴 48 ↑ +0.4
Code coverage Code coverage metrics 🟢 99 🟢 99 ↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDoc coverage Variables coverage 🟥 20 undocumented variables 🟥 20 undocumented variables  +0 %
Code coverage Line coverage 🟩 97.2 % 🟩 97 % ↓ −0.2 %
Code coverage Branch coverage 🟩 96.1 % 🟩 96.1 % ↓ −0.1 %

440 other audits are unchanged.


13 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review December 11, 2025 01:29
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanna-skryl hanna-skryl merged commit 0cf7d2a into main Dec 11, 2025
25 checks passed
@hanna-skryl hanna-skryl deleted the lighthouse-categories-api branch December 11, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 lighthouse-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants