refactor: update to nx 22 #1196

BioPhoton · 2025-12-20T23:14:55Z

This PR includes:

package version updates over running nx migrate latest
☝️ plugin-typescript int-test updates due to 2 errors less introduces by version update (errors are not in our source code but in node_modules)
☝️ plugin-typescript-e2e e2e-test updates due to 2 errors less introduces by version update (errors are not in our source code but in node_modules)
adjustments of test target defaults and e2e tests project targets (fixed a miss configuration and also could delete options)
added tests for createNodesV2 in nx-plugin
deleted logic and tests for createNodes in nx-plugin as not present in Nx v22

nx-cloud · 2025-12-20T23:16:16Z

View your CI Pipeline Execution ↗ for commit 17ddc1e

Command	Status	Duration	Result
`nx affected -t e2e-test --parallel=1`	❌ Failed	11m 34s	View ↗
`nx affected -t int-test --parallel=3`	✅ Succeeded	1m 6s	View ↗
`nx run-many --target=build --parallel=3`	✅ Succeeded	32s	View ↗

☁️ Nx Cloud last updated this comment at 2025-12-21 02:40:47 UTC

pkg-pr-new · 2025-12-21T00:01:00Z

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1196

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1196

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1196

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1196

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1196

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1196

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1196

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1196

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1196

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1196

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1196

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1196

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1196

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1196

commit: ec75ff4

…ated @nx/vite

github-actions · 2025-12-21T00:08:36Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit a9eb834 with previous commit 4f51446.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Security	🔴 43	🟡 51
Updates	🟡 71	🟡 79
Performance	🔴 47	🔴 44
Code coverage	🟡 89	🟡 89
Documentation	🔴 36	🔴 36
Axe Accessibility	🟡 88	🟡 88
Bug prevention	🟡 67	🟡 67	–
Code style	🟢 99	🟢 99	–
Type Safety	🟡 56	🟡 56	–
Miscellaneous	🟡 67	🟡 67	–
Accessibility	🟢 92	🟢 92	–
Best Practices	🟢 100	🟢 100	–
SEO	🟢 92	🟢 92	–

👍 3 groups improved, 👎 2 groups regressed, 👍 9 audits improved, 👎 5 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score
JS packages	npm audit	🔴 43	🟡 51
JS packages	npm outdated dependencies	🟡 71	🟡 79
Lighthouse	Performance	🔴 47	🔴 44
Code coverage	Code coverage metrics	🟡 89	🟡 89
JSDocs coverage	Documentation coverage	🔴 36	🔴 36

29 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
Lighthouse	Initial server response time was short	🟥 Root document took 1,350 ms	🟩 Root document took 420 ms
Lighthouse	Max Potential First Input Delay	🟥 420 ms	🟥 710 ms
Lighthouse	Total Blocking Time	🟥 700 ms	🟥 940 ms
JS packages	Vulnerabilities for npm prod dependencies.	🟨 11 vulnerabilities (3 high, 1 moderate, 7 low)	🟨 10 vulnerabilities (2 high, 1 moderate, 7 low)
JS packages	Outdated npm dev dependencies.	🟨 61 outdated package versions (35 major, 19 minor, 7 patch)	🟨 53 outdated package versions (28 major, 19 minor, 6 patch)
Lighthouse	Speed Index	🟥 6.3 s	🟥 5.8 s
JS packages	Outdated npm prod dependencies.	🟨 18 outdated package versions (7 major, 8 minor, 3 patch)	🟨 16 outdated package versions (5 major, 8 minor, 3 patch)
Lighthouse	Time to Interactive	🟥 11.4 s	🟥 12.1 s
JSDocs coverage	Variables coverage	🟥 267 undocumented variables	🟥 267 undocumented variables
Code coverage	Function coverage	🟩 90.6 %	🟩 90.9 %
Code coverage	Line coverage	🟨 84.6 %	🟨 84.7 %
JSDocs coverage	Types coverage	🟥 247 undocumented types	🟥 246 undocumented types
JSDocs coverage	Functions coverage	🟥 588 undocumented functions	🟥 587 undocumented functions
Code coverage	Branch coverage	🟨 87.2 %	🟨 87.2 %
Lighthouse	Avoids enormous network payloads	🟩 Total size was 2,057 KiB	🟩 Total size was 2,061 KiB
Lighthouse	Largest Contentful Paint	🟥 9.5 s	🟥 10.8 s
Lighthouse	Minimizes main-thread work	🟥 5.7 s	🟥 6.8 s
Lighthouse	Metrics	🟩 100%	🟩 100%
Lighthouse	JavaScript execution time	🟥 2.1 s	🟥 2.7 s
Lighthouse	Uses efficient cache policy on static assets	🟨 30 resources found	🟨 30 resources found
Lighthouse	Server Backend Latencies	🟩 1,300 ms	🟩 940 ms
Lighthouse	Reduce unused CSS	🟥 Potential savings of 95 KiB	🟥 Potential savings of 95 KiB
Lighthouse	Remove duplicate modules in JavaScript bundles	🟥 Potential savings of 105 KiB	🟥 Potential savings of 105 KiB
Lighthouse	First Contentful Paint	🟥 3.0 s	🟥 3.0 s
JS packages	Vulnerabilities for npm dev dependencies.	🟥 30 vulnerabilities (1 critical, 6 high, 18 moderate, 5 low)	🟥 24 vulnerabilities (3 critical, 6 high, 9 moderate, 6 low)
TypeScript	Semantic errors	🟥 2602 errors	🟥 2596 errors
Lighthouse	Network Round Trip Times	🟩 10 ms	🟩 10 ms

652 other audits are unchanged.

github-actions · 2025-12-21T00:15:17Z

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit a9eb834 with previous commit 4f51446.

💼 Project `nx-plugin`

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟡 85	🟡 89
Documentation	🟡 65	🟡 64

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed, 2 audits changed without impacting score

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟡 85	🟡 89
JSDocs coverage	Documentation coverage	🟡 65	🟡 64

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value
JSDocs coverage	Variables coverage	🟥 7 undocumented variables	🟥 7 undocumented variables
Code coverage	Function coverage	🟩 90 %	🟩 96.4 %
Code coverage	Line coverage	🟨 79.7 %	🟨 84.8 %
Code coverage	Branch coverage	🟨 75.6 %	🟨 76.3 %
JSDocs coverage	Types coverage	🟥 15 undocumented types	🟥 14 undocumented types
JSDocs coverage	Functions coverage	🟥 20 undocumented functions	🟥 19 undocumented functions

442 other audits are unchanged.

💼 Project `plugin-lighthouse`

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	🟢 99	🟢 99

5 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin	🗃️ Group	⭐ Previous score	⭐ Current score	🔄 Score change
Code coverage	Code coverage metrics	🟢 99	🟢 99

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin	🛡️ Audit	📏 Previous value	📏 Current value	🔄 Value change
Code coverage	Branch coverage	🟩 96.2 %	🟩 96.2 %

443 other audits are unchanged.

12 other projects are unchanged.

hanna-skryl · 2025-12-24T13:35:45Z

e2e/plugin-js-packages-e2e/project.json

    "e2e": {
-      "executor": "@nx/vite:test",
+      "executor": "@nx/vitest:test",
      "options": {
        "configFile": "{projectRoot}/vitest.e2e.config.ts"
      }


Is there a specific reason why this project's e2e target configuration differs from the rest?

hanna-skryl · 2025-12-24T13:55:25Z

packages/nx-plugin/src/plugin/types.ts

-export type NormalizedCreateNodesContext = CreateNodesContext &
-  CreateTargetsOptions;


targets.unit.test.ts is still using NormalizedCreateNodesContext type.

hanna-skryl · 2025-12-24T13:58:22Z

packages/nx-plugin/src/plugin/plugin.unit.test.ts

      nxJsonConfiguration: {},
-      workspaceRoot: '',
+      workspaceRoot: MEMFS_VOLUME,
      configFiles: [],


CreateNodesContextV2 type doesn't have a configFiles property.

hanna-skryl · 2025-12-24T14:10:40Z

packages/nx-plugin/src/executors/cli/utils.unit.test.ts

beforeAll and afterAll imports are missing in this file.

hanna-skryl · 2025-12-24T14:11:08Z

packages/nx-plugin/src/plugin/plugin.unit.test.ts

The it import is missing in this file.

hanna-skryl · 2025-12-24T14:11:26Z

packages/nx-plugin/src/plugin/utils.unit.test.ts

The it import is missing in this file.

refactor: update to nx 22

e6277bd

github-actions bot assigned BioPhoton Dec 20, 2025

github-actions bot added the 🛠️ tooling label Dec 20, 2025

John Doe added 3 commits December 21, 2025 00:55

refactor: use @nx/vitest executor in favour of deprecated @nx/vite

1d1e89f

test(plugin-typescript): remove node_module errors from tests as gone

f225e90

fix(nx-plugin): remove createNode v1 logic and int + unit tests

222aaa9

github-actions bot added 🔬 testing writing tests 🧩 nx-plugin 🧩 typescript-plugin TypeScript plugin labels Dec 20, 2025

refactor: refactor e2e to use @nx/vitest executor in favour of deprec…

fe44df4

…ated @nx/vite

John Doe added 3 commits December 21, 2025 01:20

refactor: remove test target matching on executor

0cb9223

test(plugin-typescript-e2e): fix e2e test

4a9c833

chore: reduce e2e target options

cfc3a4a

BioPhoton marked this pull request as ready for review December 21, 2025 00:35

John Doe added 6 commits December 21, 2025 01:39

chore: adjust default targets

72bff1e

test(nx-plugin): add setup helper

45ea156

test(nx-plugin): add setup helper

f5012a4

test(nx-plugin): add setup helper

60b83a9

chore: cleanup targets

074a6e6

chore(nx-plugin): reduce loc in tests

c0059f3

BioPhoton requested review from matejchalk and removed request for matejchalk December 21, 2025 01:29

BioPhoton marked this pull request as draft December 21, 2025 01:48

John Doe added 3 commits December 21, 2025 02:50

refactor: wip

d3240f9

refactor: wip

d13d42e

refactor: wip

703cd6a

refactor: wip

ec75ff4

BioPhoton mentioned this pull request Dec 21, 2025

Small Cleanups #1168

Open

10 tasks

refactor: wip

17ddc1e

BioPhoton marked this pull request as ready for review December 21, 2025 02:31

BioPhoton requested a review from matejchalk December 21, 2025 02:32

BioPhoton enabled auto-merge (squash) December 21, 2025 02:38

BioPhoton requested a review from hanna-skryl December 21, 2025 15:51

hanna-skryl reviewed Dec 24, 2025

View reviewed changes

		export type NormalizedCreateNodesContext = CreateNodesContext &
		CreateTargetsOptions;

refactor: update to nx 22 #1196

Are you sure you want to change the base?

refactor: update to nx 22 #1196

Conversation

BioPhoton commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

🏷️ Categories

🗃️ Groups

🛡️ Audits

Uh oh!

github-actions bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code PushUp

💼 Project nx-plugin

🗃️ Groups

🛡️ Audits

💼 Project plugin-lighthouse

🗃️ Groups

🛡️ Audits

Uh oh!

hanna-skryl Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

hanna-skryl Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BioPhoton commented Dec 20, 2025 •

edited

Loading

nx-cloud bot commented Dec 20, 2025 •

edited

Loading

pkg-pr-new bot commented Dec 21, 2025 •

edited

Loading

github-actions bot commented Dec 21, 2025 •

edited

Loading

github-actions bot commented Dec 21, 2025 •

edited

Loading

💼 Project `nx-plugin`

💼 Project `plugin-lighthouse`