Skip to content

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Oct 15, 2024

Precondition:

This PR uses nx-verdaccio for the cli-e2e project only. In the precondition PR #842 the e2e target gets refactored and the tooling code gets a cleanup

@github-actions github-actions bot added 🔬 testing writing tests 🦾 CI/CD Continuous integration and deployment 🛠️ tooling labels Oct 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 63fc1f1 with source commit 13a63a4.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 45 ↓ −9.1
Updates 🟡 75 🟡 75 ↑ +0.1
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 45 ↓ −9.1
JS Packages NPM outdated dependencies 🟡 75 🟡 75 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 610 ms 🟩 Root document took 420 ms ↓ −31.2 %
Lighthouse Speed Index 🟨 5.5 s 🟥 7.4 s ↑ +34.4 %
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.9 s ↑ +26.3 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.2 s ↑ +3.6 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟨 3.2 s ↑ +3.6 %
JS Packages Outdated NPM dev dependencies. 🟨 57 outdated package versions (33 major, 15 minor, 1 preminor, 7 patch, 1 prerelease) 🟨 58 outdated package versions (33 major, 15 minor, 1 preminor, 7 patch, 2 prerelease) ↑ +1.8 %
Lighthouse Minimizes main-thread work 🟥 19.1 s 🟥 22.3 s ↑ +16.7 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,170 ms 🟥 Potential savings of 170 ms ↓ −85.7 %
Lighthouse JavaScript execution time 🟥 9.9 s 🟥 10.8 s ↑ +8.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −2.8 %
Lighthouse Time to Interactive 🟥 17.6 s 🟥 17.1 s ↓ −2.8 %
Lighthouse Max Potential First Input Delay 🟥 3,230 ms 🟥 3,660 ms ↑ +13.5 %
Lighthouse Total Blocking Time 🟥 7,370 ms 🟥 7,670 ms ↑ +4.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 70 KiB ↑ +93.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,812 KiB 🟩 Total size was 1,812 KiB ↑ +0.1 %
Lighthouse Server Backend Latencies 🟩 130 ms 🟩 200 ms ↑ +57.2 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 100 ms ↑ +39.8 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %

495 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2024

Code PushUp

😟 Code PushUp report has regressed – compared target commit d40a552 with source commit 7e6c29d.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 48 ↓ −5.6
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 88 🟡 88
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👎 1 group regressed, 👎 3 audits regressed, 14 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 48 ↓ −5.6

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 3.7 s ↑ +24.2 %
Lighthouse Speed Index 🟥 6.8 s 🟥 7.3 s ↑ +8.1 %
Lighthouse Time to Interactive 🟥 14.6 s 🟥 15.1 s ↑ +3.8 %
Lighthouse Total Blocking Time 🟥 4,740 ms 🟥 9,280 ms ↑ +96 %
Lighthouse Minimizes main-thread work 🟥 19.0 s 🟥 20.3 s ↑ +7.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,820 KiB 🟩 Total size was 1,819 KiB ↓ −0.1 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +3.8 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 710 ms 🟥 Potential savings of 250 ms ↓ −64.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 72 KiB 🟥 Potential savings of 82 KiB ↓ −100 %
Lighthouse JavaScript execution time 🟥 9.5 s 🟥 9.7 s ↑ +2.4 %
Lighthouse Max Potential First Input Delay 🟥 2,740 ms 🟥 2,550 ms ↓ −6.8 %
Lighthouse Server Backend Latencies 🟩 250 ms 🟩 320 ms ↑ +31.5 %
Lighthouse Initial server response time was short 🟩 Root document took 500 ms 🟩 Root document took 490 ms ↓ −2.2 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.8 s ↓ −0.1 %
Lighthouse Avoids an excessive DOM size 🟥 2,243 elements 🟥 2,242 elements ↓ −0.1 %
Lighthouse Network Round Trip Times 🟩 80 ms 🟩 80 ms ↑ +0.3 %

496 other audits are unchanged.

matejchalk pushed a commit that referenced this pull request Nov 5, 2024
This PR uses `nx-verdaccio` for all but `cli-e2e` project. In a follow
up PR #844 the `e2e-old` target gets refactored and the tooling code
gets a cleanup

---------

Signed-off-by: Vojtech Masek <[email protected]>
Co-authored-by: Vojtech Masek <[email protected]>
Co-authored-by: hanna-skryl <[email protected]>
@BioPhoton BioPhoton closed this Nov 10, 2024
@BioPhoton BioPhoton deleted the use-nx-verdaccio-for-cli-e2e branch December 6, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🦾 CI/CD Continuous integration and deployment 🔬 testing writing tests 🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants