Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Nov 25, 2024

Feature request from @getlarge:

Is there a way to avoid the effect of persistCliOptions? It messes up with our Nx outputs configuration where each project is supposed to have its own folder under .code-pushup to avoid clashes ("{workspaceRoot}/.code-pushup/{projectRoot}")

Added output option for customizing persist.outputDir. Default is '.code-pushup'. Supports '.code-pushup/{project}' pattern, so that projects in monorepo can have different output folders to simplify cache configuration.

Will expose this input in GitHub and GitLab integrations once this has been merged and released.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 ci labels Nov 25, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Code PushUp

🥳 Code PushUp report has improved – compared target commit e183b8c with source commit 3db30da.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Security 🟡 73 🟡 78 ↑ +4.9
Performance 🔴 48 🟡 50 ↑ +2
Code coverage 🟢 90 🟢 90 ↑ +0.1
Custom checks 🟡 67 🟡 67
Updates 🟡 76 🟡 76
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 3 groups improved, 👍 8 audits improved, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM audit 🟡 73 🟡 78 ↑ +4.9
Lighthouse Performance 🔴 48 🟡 50 ↑ +2
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

17 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JS Packages Vulnerabilities for NPM dev dependencies. 🟥 26 vulnerabilities (4 high, 22 low) 🟥 9 vulnerabilities (4 high, 1 moderate, 4 low) ↓ −65.4 %
Lighthouse Speed Index 🟥 6.8 s 🟥 6.0 s ↓ −11 %
Lighthouse First Contentful Paint 🟥 3.0 s 🟨 2.8 s ↓ −5.4 %
Lighthouse Time to Interactive 🟥 16.8 s 🟥 14.8 s ↓ −11.6 %
Lighthouse Largest Contentful Paint 🟨 3.6 s 🟨 3.6 s ↓ −0.3 %
Code coverage Function coverage 🟩 92.7 % 🟩 92.9 % ↑ +0.2 %
Code coverage Branch coverage 🟨 85 % 🟨 85.1 % ↑ +0.1 %
Code coverage Line coverage 🟩 90.5 % 🟩 90.6 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,834 KiB 🟩 Total size was 1,826 KiB ↓ −0.4 %
Lighthouse Minimizes main-thread work 🟥 20.0 s 🟥 16.6 s ↓ −16.6 %
Lighthouse Total Blocking Time 🟥 7,470 ms 🟥 4,610 ms ↓ −38.3 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −11.6 %
Lighthouse JavaScript execution time 🟥 10.0 s 🟥 8.5 s ↓ −14.9 %
Lighthouse Max Potential First Input Delay 🟥 2,750 ms 🟥 2,150 ms ↓ −21.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↑ +0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 800 ms 🟥 Potential savings of 1,060 ms ↑ +32.5 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 30 ms ↓ −56.7 %
Lighthouse Server Backend Latencies 🟩 220 ms 🟩 230 ms ↑ +5.2 %
Lighthouse Initial server response time was short 🟩 Root document took 410 ms 🟩 Root document took 410 ms ↑ +1.5 %

494 other audits are unchanged.

@matejchalk matejchalk force-pushed the ci-custom-persist-options branch from 0b64911 to eb6cbbf Compare November 25, 2024 11:59
@matejchalk matejchalk marked this pull request as ready for review November 25, 2024 13:00
@matejchalk matejchalk merged commit e735bf4 into main Nov 25, 2024
18 checks passed
@matejchalk matejchalk deleted the ci-custom-persist-options branch November 25, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 ci 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants