Add rules from @typescript-eslint/stylistic-type-checked

matejchalk · matejchalk · commit 510f1b5d13bf · 2024-10-04T14:26:57.000+02:00
closes #4
diff --git a/docs/angular-ngrx.md b/docs/angular-ngrx.md
@@ -47,9 +47,9 @@ Config for **Angular** projects using **NgRx** library.
    }
    ```
 
-## 📏 Rules (372)
+## 📏 Rules (382)
 
-**342** rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-342). For brevity, only the **30** additional rules are listed in this document.
+**352** rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-352). For brevity, only the **30** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/angular.md b/docs/angular.md
@@ -47,9 +47,9 @@ Config for **Angular** projects.
    }
    ```
 
-## 📏 Rules (372)
+## 📏 Rules (382)
 
-**297** rules are included from [`@code-pushup/eslint-config/typescript`](./typescript.md#📏-rules-297). For brevity, only the **75** additional rules are listed in this document.
+**307** rules are included from [`@code-pushup/eslint-config/typescript`](./typescript.md#📏-rules-307). For brevity, only the **75** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/graphql.md b/docs/graphql.md
@@ -33,9 +33,9 @@ Config for **GraphQL servers** implemented in Node.js.
    }
    ```
 
-## 📏 Rules (294)
+## 📏 Rules (301)
 
-**267** rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-267). For brevity, only the **27** additional rules are listed in this document.
+**274** rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-274). For brevity, only the **27** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/index.md b/docs/index.md
diff --git a/docs/node.md b/docs/node.md
@@ -19,9 +19,9 @@ Config for **Node.js** projects.
    }
    ```
 
-## 📏 Rules (255)
+## 📏 Rules (262)
 
-**251** rules are included from [the default config](./index.md#📏-rules-251). For brevity, only the **4** additional rules are listed in this document.
+**258** rules are included from [the default config](./index.md#📏-rules-258). For brevity, only the **4** additional rules are listed in this document.
 
 > 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
 
diff --git a/docs/typescript.md b/docs/typescript.md
diff --git a/index.js b/index.js
@@ -109,16 +109,32 @@ module.exports = {
     yoda: 'warn',
 
     // https://typescript-eslint.io/rules/
-    '@typescript-eslint/default-param-last': 'warn',
+    '@typescript-eslint/array-type': 'warn',
+    '@typescript-eslint/adjacent-overload-signatures': 'warn',
+    '@typescript-eslint/ban-tslint-comment': 'warn',
     // TODO - remove condition after updating to "@typescript-eslint/eslint-plugin": "^7.0.0" in peerDependencies
     // add new "class-methods-use-this" rule (added in @typescript-eslint/eslint-plugin@6.2.0)
     ...(typescriptEslint.rules['class-methods-use-this']
       ? {
           '@typescript-eslint/class-methods-use-this': 'warn',
         }
       : {}),
+    '@typescript-eslint/consistent-generic-constructors': 'warn',
+    '@typescript-eslint/default-param-last': 'warn',
     '@typescript-eslint/max-params': ['warn', { max: 4 }],
     '@typescript-eslint/method-signature-style': 'warn',
+    '@typescript-eslint/no-confusing-non-null-assertion': 'warn',
+    '@typescript-eslint/no-empty-function': [
+      'warn',
+      {
+        allow: [
+          'private-constructors',
+          'protected-constructors',
+          'decoratedFunctions',
+          'overrideMethods',
+        ],
+      },
+    ],
     '@typescript-eslint/no-import-type-side-effects': 'warn',
     '@typescript-eslint/no-magic-numbers': [
       'warn',
@@ -134,6 +150,7 @@ module.exports = {
         detectObjects: true,
       },
     ],
+    '@typescript-eslint/prefer-function-type': 'warn',
     '@typescript-eslint/no-require-imports': 'error',
     '@typescript-eslint/no-shadow': 'warn',
     '@typescript-eslint/no-unused-expressions': 'warn',
@@ -169,6 +186,7 @@ module.exports = {
         curly: 'off',
         '@typescript-eslint/no-non-null-assertion': 'off',
         '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-empty-function': 'off',
         'sonarjs/no-duplicate-string': 'off',
         'unicorn/consistent-function-scoping': 'off',
         'functional/no-let': 'off',
@@ -197,6 +215,7 @@ module.exports = {
       rules: {
         // DISABLED RULES FOR GENERATED FILES
 
+        '@typescript-eslint/ban-tslint-comment': 'off',
         'unicorn/no-abusive-eslint-disable': 'off',
       },
     },
diff --git a/tests/configs/typescript.spec.js b/tests/configs/typescript.spec.js
@@ -46,7 +46,6 @@ describe('typescript config', () => {
       .sort();
     expect(rulesWithoutTypes).toEqual([
       '@typescript-eslint/consistent-type-assertions',
-      '@typescript-eslint/no-explicit-any',
     ]);
   });
 
diff --git a/tests/helpers/lint-utils.js b/tests/helpers/lint-utils.js
@@ -38,7 +38,7 @@ function setupLintUtils(config, defaultFilePath = '*.ts') {
    * @returns {string[]}
    */
   const getExplicitRuleIds = config => [
-    ...Object.keys(config.rules ?? {}),
+    ...Object.keys(config.rules ?? {}).filter(id => config.rules[id] !== 'off'),
     ...(config.overrides?.flatMap(getExplicitRuleIds) ?? []),
   ];
 
diff --git a/typescript.js b/typescript.js
@@ -61,6 +61,7 @@ module.exports = {
 
         '@typescript-eslint/unbound-method': 'off',
         '@typescript-eslint/no-unsafe-enum-comparison': 'off',
+        'unicorn/prefer-string-starts-ends-with': 'off', // superseded by @typescript-eslint/prefer-string-starts-ends-with
 
         // ADDITIONAL RULES
 
@@ -72,6 +73,10 @@ module.exports = {
             objectLiteralTypeAssertions: 'never',
           },
         ],
+        '@typescript-eslint/dot-notation': [
+          'warn',
+          { allowIndexSignaturePropertyAccess: true },
+        ],
         '@typescript-eslint/naming-convention': [
           'warn',
           ...NAMING_CONVENTION_OPTIONS,
@@ -83,6 +88,13 @@ module.exports = {
               '@typescript-eslint/no-unsafe-unary-minus': 'error',
             }
           : {}),
+        '@typescript-eslint/non-nullable-type-assertion-style': 'error',
+        '@typescript-eslint/prefer-nullish-coalescing': [
+          'warn',
+          { ignorePrimitives: { string: true, boolean: true } },
+        ],
+        '@typescript-eslint/prefer-optional-chain': 'warn',
+        '@typescript-eslint/prefer-string-starts-ends-with': 'warn',
 
         // https://github.com/eslint-functional/eslint-plugin-functional#rules
         'functional/immutable-data': [
@@ -116,6 +128,14 @@ module.exports = {
                 objectLiteralTypeAssertions: 'allow',
               },
             ],
+            '@typescript-eslint/dot-notation': [
+              'warn',
+              {
+                allowPrivateClassPropertyAccess: true,
+                allowProtectedClassPropertyAccess: true,
+                allowIndexSignaturePropertyAccess: true,
+              },
+            ],
             '@typescript-eslint/require-await': 'warn',
             'functional/immutable-data': [
               'warn',

Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,9 @@ Config for Angular projects using NgRx library.`
`47`	`47`	`}`
`48`	`48`	```
`49`	`49`
`50`		`-## 📏 Rules (372)`
	`50`	`+## 📏 Rules (382)`
`51`	`51`
`52`		-342 rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-342). For brevity, only the 30 additional rules are listed in this document.
	`52`	+352 rules are included from [`@code-pushup/eslint-config/angular`](./angular.md#📏-rules-352). For brevity, only the 30 additional rules are listed in this document.
`53`	`53`
`54`	`54`	> 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
`55`	`55`
Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,9 @@ Config for GraphQL servers implemented in Node.js.`
`33`	`33`	`}`
`34`	`34`	```
`35`	`35`
`36`		`-## 📏 Rules (294)`
	`36`	`+## 📏 Rules (301)`
`37`	`37`
`38`		-267 rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-267). For brevity, only the 27 additional rules are listed in this document.
	`38`	+274 rules are included from [`@code-pushup/eslint-config/node`](./node.md#📏-rules-274). For brevity, only the 27 additional rules are listed in this document.
`39`	`39`
`40`	`40`	> 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,9 @@ Config for Node.js projects.`
`19`	`19`	`}`
`20`	`20`	```
`21`	`21`
`22`		`-## 📏 Rules (255)`
	`22`	`+## 📏 Rules (262)`
`23`	`23`
`24`		`-251 rules are included from [the default config](./index.md#📏-rules-251). For brevity, only the 4 additional rules are listed in this document.`
	`24`	`+258 rules are included from [the default config](./index.md#📏-rules-258). For brevity, only the 4 additional rules are listed in this document.`
`25`	`25`
`26`	`26`	> 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).<br>💡 Manually fixable by [editor suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions).<br>🧪🚫 Disabled for [test files](../README.md#🧪-test-overrides).<br>🧪⚠️ Severity lessened to warning for [test files](../README.md#🧪-test-overrides).
`27`	`27`