Skip to content

Conversation

code-schreiber
Copy link
Owner

No description provided.

@ReviewMeBot
Copy link

ReviewMeBot commented Jun 7, 2019

2 Warnings
⚠️ Please provide a PR description
⚠️ This PR is quite a big one! Try splitting this into separate tasks next time 🙂
1 Message
📖 Thank you for your work @code-schreiber 🎉 You might find a few suggestions from me below 😉

Detekt found issues

warning (1)

File Line Reason
app/src/main/java/com/toolslab/reviewme/MainActivity.kt 11 This comment contains text that has been defined as forbidden in detekt.

Generated by 🚫 Danger

package="com.toolslab.reviewme">

<application>
<application
Copy link

@ReviewMeBot ReviewMeBot Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Should explicitly set android:icon, there is no default

setContentView(R.layout.activity_main)
// TODO: Forgotten todo
}

Copy link

@ReviewMeBot ReviewMeBot Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Unexpected blank line(s) before “}”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants