-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(deps): upgrade to Spring Boot 4 #4558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ahoehma
wants to merge
8
commits into
codecentric:master
Choose a base branch
from
ahoehma:feat/migrate-to-springboot-4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolokia-support-spring is also not ready yet for spring-boot 4: jolokia/jolokia#866 |
- I did "mvn install -DskipTests=true -nsu -Dcheckstyle.skip=false -pl '!spring-boot-admin-docs'" - spring-boot-admin-docs doesn't build successfully no glue why
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- the CountDownLatch.await should have a timeout too
…re.MailSenderAutoConfiguration] - some tests failing because of missing MailSenderAutoConfiguration - adding spring-boot-starter-mail in test-scope
- wee need both starters because of import of RestTemplateAutoConfiguration, RestClientAutoConfiguration and WebClientAutoConfiguration in SpringBootAdminClientAutoConfiguration - locally (win 11, gitbash, eclipse) ClientServletApplicationTest not working, the --spring.jackson.property-naming-strategy=SNAKE_CASE is not used (no glue why) - in github build its working - why is this? - locally SpringBootAdminClientRegistrationClientAutoConfigurationTest is also not working 100% - a lot of "wrong" RegistrationClient are created, doesn't matter which "builders" are in the spring context - in github build its working - why is this?
c6403c2
to
13573fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.