Skip to content

Conversation

@kobenguyent
Copy link

No description provided.

@kobenguyent kobenguyent changed the title fix: Update puppeteer.yml fix: Update deps and make ci work May 13, 2025
@kobenguyent kobenguyent requested a review from Copilot May 13, 2025 15:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dependency versions and modifies the CI workflows to ensure compatibility with current environments.

  • Updated dependency versions in package.json for codeceptjs, puppeteer, webdriverio, and pollyjs libraries.
  • Upgraded actions (checkout and setup-node) and Node.js runtime version in GitHub workflow files for both WebDriver and Puppeteer.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Dependency versions updated to support new releases and improve CI compatibility
.github/workflows/webdriver.yml CI workflow updated: changed to ubuntu-latest, Node.js 20.x, and upgraded checkout/setup actions
.github/workflows/puppeteer.yml CI workflow updated: changed to ubuntu-latest, Node.js 20.x, upgraded checkout/setup actions, and added package installation commands
Comments suppressed due to low confidence (3)

.github/workflows/puppeteer.yml:30

  • Consider adding the '-y' flag to the apt-get install commands to ensure non-interactive installation in the CI environment.
sudo apt-get install php

.github/workflows/webdriver.yml:21

  • [nitpick] There are two consecutive checkout actions; please verify if both are necessary or if they can be consolidated for clarity.
- uses: actions/checkout@v3

.github/workflows/puppeteer.yml:31

  • [nitpick] Similar to the webdriver workflow, there is a duplicate checkout action; if this is intentional for checking out a separate repository, a clarifying comment could help future maintainers.
- uses: actions/checkout@v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants