Skip to content

⚡️ Speed up function _get_slice_subplot_info by 49% #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −5
Open

⚡️ Speed up function _get_slice_subplot_info by 49% #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions optuna/visualization/_slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,29 @@ def _target(t: FrozenTrial) -> float:
constraints=[],
)

x_append = plot_info.x.append
y_append = plot_info.y.append
trial_numbers_append = plot_info.trial_numbers.append
constraints_append = plot_info.constraints.append

for t in trials:
if param not in t.params:
param_value = t.params.get(param, None)
if param_value is None:
continue
plot_info.x.append(t.params[param])
plot_info.y.append(target(t))
plot_info.trial_numbers.append(t.number)
x_append(param_value)
y_append(target(t))
trial_numbers_append(t.number)
constraints = t.system_attrs.get(_CONSTRAINTS_KEY)
plot_info.constraints.append(constraints is None or all([x <= 0.0 for x in constraints]))
# Avoid intermediate list creation for all([...])
if constraints is None or not constraints:
is_feasible = True
else:
is_feasible = True
for x in constraints:
if x > 0.0:
is_feasible = False
break
constraints_append(is_feasible)

return plot_info

Expand Down