fix: do not wipe claude buffer on window close (native) #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarosevilla95
changed the title
alvarosevilla95
force-pushed
the
fix/terminal-window-validation
branch
from
e942ac9 to
8101128
Compare
|
Hey, thanks for opening this PR. What's the difference between this new field and the already existing |
alvarosevilla95
force-pushed
the
fix/terminal-window-validation
branch
from
8101128 to
ef0592f
Compare
I think I overcomplicated this a bit. The main issue was that on the native provider, closing the claude window triggered a buffer delete, rather than hiding it as it happens on |
alvarosevilla95
changed the title
|
You'll have to update the tests, as they still expect |
|
ah yes sorry, forgot about that 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
nativeprovider had a behavior where closing the claude window wiped the buffer, rather than hiding it, which is different from the snacks behavior. It means it was very easy to accidentally terminate the session when trying to hide the buffer.This changes it so the buffer is hidden on close instead, behaving like
snacks