feat: support send-to-claude for snacks.explorer
#68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end) This PR aims to add an equivalent "ClaudeCodeSend" integration for snacks.explorer, as what already exists for nvim-tree, neo-tree and oil.nvim Snacks.explorer seems to have become the default LazyVim file explorer, and has gained a fair bit of traction. - Add snacks_picker_list filetype detection across the codebase - Implement _get_snacks_explorer_selection() to handle file selection - Support both individual selection and current file fallback - Handle visual mode for snacks.explorer in visual commands - Add comprehensive test coverage for the new integration
…xplorer Enable selecting multiple files in snacks.explorer using vim's visual mode. This brings the snacks.explorer integration up to par with others, such as oil, nvim-tree and NvimTree - Pass visual range parameters to _get_snacks_explorer_selection() - Use picker's list API to convert row numbers to items (row2idx/get) - Handle edge cases like nil items and empty file paths - Add comprehensive test coverage for visual selection scenarios
- Fix helpers module usage in snacks_explorer_spec.lua (return function, not table) - Add missing vim.fn.isDirectory() and vim.bo to test mocks - Fix is_safe_path() to properly filter system files (/etc/, /usr/, /bin/, /sbin/) - All 326 tests now pass successfully
andresthor
force-pushed
the
feat/support-send-for-snacks-explorer
branch
from
dc3c2e1 to
6fd3196
Compare
Change-Id: I6c810fbb8c3c0eedcff14ebe491f2f5825ee209f Signed-off-by: Thomas Kosiewski <[email protected]>
Change-Id: I6c28f07bace2e3236e6cc054a5e56dc49e6dc125 Signed-off-by: Thomas Kosiewski <[email protected]>
ThomasK33
requested changes
Jul 29, 2025
There was a problem hiding this comment.
Thanks for the PR @andresthor.
Just so you know, I've pushed a fixture for the snacks explorer onto your branch to check if it works.
Can we please remove the 'security' features of omitting specific paths?
Comment on lines
+309
to
+311
| -- Helper function to check if path is safe (not root-level) | ||
| local function is_safe_path(file_path) | ||
| if not file_path or file_path == "" then |
There was a problem hiding this comment.
Why are we adding this?
If I navigate to /etc in my file explorer, I want the file to be propagated as an @ mention.
| @@ -24,7 +24,7 @@ return { | |||
| "<leader>as", | |||
| "<cmd>ClaudeCodeTreeAdd<cr>", | |||
| desc = "Add file from tree", | |||
| ft = { "NvimTree", "neo-tree", "oil" }, | |||
| ft = { "NvimTree", "neo-tree", "oil", "snacks_picker_list" }, -- snacks.explorer uses "snacks_picker_list" filetype | |||
There was a problem hiding this comment.
Cool, but this comment doesn't add any context here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add send-to-claude for the
folke/snacks.explorerto work with the pluginIt looks like
Snacks.explorerhas become the default file browser for LazyVim, so it makes sense we'll start seeing more of those feature requests.Adds support for snacks.explorer to claudecode.nvim, bringing feature parity with existing file explorer integrations, such as
nvim-tree,neo-treeandoil.nvim.Implementation
Follows established patterns in
integrations.lua:snacks_picker_listfiletype_get_snacks_explorer_selection()using picker APIFeatures
/etc/passwd,/usr/bin/vim)Testing
Comprehensive test coverage:
Documentation
snacks_picker_listfiletypeEnables snacks.explorer users to add files to Claude's context using familiar vim motions, just like other supported file explorers.