Skip to content

fix: stop vpn binary on startup failure #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

fix: stop vpn binary on startup failure #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Vpn.Service/Manager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,10 @@ await _tunnelSupervisor.StartAsync(_config.TunnelBinaryPath, HandleTunnelRpcMess
if (reply.MsgCase != TunnelMessage.MsgOneofCase.Start)
throw new InvalidOperationException("Tunnel did not reply with a Start response");

// If the tunnel failed to start, stop the subprocess.
if (!reply.Start.Success)
await _tunnelSupervisor.StopAsync(ct);

await BroadcastStatus(reply.Start.Success ? TunnelStatus.Started : TunnelStatus.Stopped, ct);
return reply.Start;
}
Expand Down
Loading