Skip to content

chore: setup testing libraries and tests for App.tsx #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 12, 2025
Merged

chore: setup testing libraries and tests for App.tsx #55

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f5f6dc4
chore: add testing deps
brettkolodny Aug 5, 2025
e868174
chore: add testing config and monaco editor mock
brettkolodny Aug 5, 2025
55ffa4b
chore: add testing for App.tsx
brettkolodny Aug 5, 2025
0df661a
chore: setup testing workflow
brettkolodny Aug 5, 2025
b9cd244
chore: remove uneeded vitest config settings
brettkolodny Aug 11, 2025
479f584
chore: update pnpm setup version
brettkolodny Aug 11, 2025
14b1d44
chore: remove unused coverage config
brettkolodny Aug 11, 2025
c606ce4
chore: add lint step to test workflow
brettkolodny Aug 11, 2025
411a789
chore: merge wasm loading state tests
brettkolodny Aug 11, 2025
25f24f6
chore: remove lint check from this PR
brettkolodny Aug 11, 2025
dde7125
chore: bump pnpm version in workflow
brettkolodny Aug 11, 2025
74d1f4c
chore: change pnpm version to match package.json
brettkolodny Aug 11, 2025
f5c526b
chore: use correct pnpm version
brettkolodny Aug 11, 2025
0337064
chore: use correct pnpm version
brettkolodny Aug 11, 2025
9c2bbbf
chore: use matching pnpm version in workflow
brettkolodny Aug 11, 2025
2a61cc3
chore: use pnpm version with hash
brettkolodny Aug 12, 2025
3b8f935
chore: remove globals from vitest config
brettkolodny Aug 12, 2025
c9a4075
chore: remove css from vitest config
brettkolodny Aug 12, 2025
2401b0e
chore: remove pnpm version from workflow so it infers from package.json
brettkolodny Aug 12, 2025
97057a7
chore: rename workflow
brettkolodny Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: Test

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]

jobs:
test:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'

- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 10.14.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and speaking of corepack, I wonder if we should just lean on it here. at the very least, the docs for this action say that it'll infer version from package.json and we should lean on that. https://github.com/pnpm/action-setup?tab=readme-ov-file#version


- name: Install dependencies
run: pnpm install

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install dependencies
run: pnpm biome check

tho eslint is also in here I guess? do we need both or can we get rid of eslint?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not using eslint in this. I want to do another PR where I set up knip and clean up the dev dependencies

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is said issues and I think I'll make it a fast follow to this PR. Even including the lint check in the PR is going to bloat the diff

- name: Run tests
run: pnpm test
2 changes: 1 addition & 1 deletion biome.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"clientKind": "git"
},
"files": {
"includes": ["src/**/*", "!src/client/gen/types.ts","!pnpm-lock.yaml"],
"includes": ["**/*.config.ts", "src/**/*", "!src/client/gen/types.ts","!pnpm-lock.yaml"],
"ignoreUnknown": true
},
"linter": {
Expand Down
16 changes: 13 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@
"dev": "vite",
"build": "tsc -b && vite build && vite build --mode=client",
"lint": "eslint .",
"preview": "vite preview"
"preview": "vite preview",
"test": "vitest",
"test:ui": "vitest --ui",
"test:run": "vitest run",
"test:coverage": "vitest run --coverage",
"test:watch": "vitest watch"
},
"dependencies": {
"@fontsource-variable/inter": "^5.2.5",
Expand Down Expand Up @@ -60,6 +65,8 @@
"@biomejs/biome": "2.1.1",
"@eslint/js": "^9.25.0",
"@hono/vite-dev-server": "^0.19.1",
"@testing-library/jest-dom": "^6.6.4",
"@testing-library/react": "^16.3.0",
"@types/lodash": "^4.17.17",
"@types/node": "^22.15.21",
"@types/prismjs": "^1.26.5",
Expand All @@ -73,12 +80,15 @@
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-react-refresh": "^0.4.19",
"globals": "^16.0.0",
"happy-dom": "^18.0.1",
"postcss": "^8.5.3",
"tailwindcss": "3",
"typescript": "~5.8.3",
"typescript-eslint": "^8.30.1",
"vercel": "^42.3.0",
"vite": "^6.3.5",
"vite-plugin-vercel": "^9.0.7"
}
"vite-plugin-vercel": "^9.0.7",
"vitest": "^3.2.4"
},
"packageManager": "[email protected]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should get corepack use [email protected] to insert the hash here

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

\n

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor removes trailing new lines, is there a reason to have it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short answer: yes.

long answer: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having some issues with getting helix not to strip the new line. But this will be fixed once this PR is merged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. the docs claim that insert-final-newline defaults to true, and it doesn't seem like you've had this issue on other files. weird.

Loading