Skip to content

Commit 2370061

Browse files
committed
Update RDP icon paths and remove unused variables
- Changed icon paths from "/icon/desktop.svg" to "/icon/rdp.svg" in local-windows-rdp tests. - Removed `resource_id` variable and related references in windows-rdp module tests and examples. - Updated default `devolutions_gateway_version` to "2025.2.2" in Terraform configuration for windows-rdp module.
1 parent d646eec commit 2370061

File tree

4 files changed

+4
-13
lines changed

4 files changed

+4
-13
lines changed

registry/coder/modules/local-windows-rdp/main.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe("local-windows-rdp", async () => {
7373
expect(app).not.toBeNull();
7474
expect(app?.slug).toBe("rdp-desktop");
7575
expect(app?.display_name).toBe("RDP Desktop");
76-
expect(app?.icon).toBe("/icon/desktop.svg");
76+
expect(app?.icon).toBe("/icon/rdp.svg");
7777
expect(app?.external).toBe(true);
7878

7979
// Verify the URI format
@@ -95,7 +95,7 @@ describe("local-windows-rdp", async () => {
9595
// Verify the script was created
9696
expect(script).not.toBeNull();
9797
expect(script?.display_name).toBe("Configure RDP");
98-
expect(script?.icon).toBe("/icon/desktop.svg");
98+
expect(script?.icon).toBe("/icon/rdp.svg");
9999
expect(script?.run_on_start).toBe(true);
100100
expect(script?.run_on_stop).toBe(false);
101101

registry/coder/modules/windows-rdp/README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ module "windows_rdp" {
1818
source = "registry.coder.com/coder/windows-rdp/coder"
1919
version = "1.2.2"
2020
agent_id = resource.coder_agent.main.id
21-
resource_id = resource.aws_instance.dev.id
2221
}
2322
```
2423

@@ -36,7 +35,6 @@ module "windows_rdp" {
3635
source = "registry.coder.com/coder/windows-rdp/coder"
3736
version = "1.2.2"
3837
agent_id = resource.coder_agent.main.id
39-
resource_id = resource.aws_instance.dev.id
4038
}
4139
```
4240

@@ -48,7 +46,6 @@ module "windows_rdp" {
4846
source = "registry.coder.com/coder/windows-rdp/coder"
4947
version = "1.2.2"
5048
agent_id = resource.coder_agent.main.id
51-
resource_id = resource.google_compute_instance.dev[0].id
5249
}
5350
```
5451

@@ -60,7 +57,6 @@ module "windows_rdp" {
6057
source = "registry.coder.com/coder/windows-rdp/coder"
6158
version = "1.2.2"
6259
agent_id = resource.coder_agent.main.id
63-
resource_id = resource.aws_instance.dev.id
64-
devolutions_gateway_version = "2025.1.6" # Specify a specific version
60+
devolutions_gateway_version = "2025.2.2" # Specify a specific version
6561
}
6662
```

registry/coder/modules/windows-rdp/main.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88

99
type TestVariables = Readonly<{
1010
agent_id: string;
11-
resource_id: string;
1211
share?: string;
1312
admin_username?: string;
1413
admin_password?: string;
@@ -45,13 +44,11 @@ describe("Web RDP", async () => {
4544
await runTerraformInit(import.meta.dir);
4645
testRequiredVariables<TestVariables>(import.meta.dir, {
4746
agent_id: "foo",
48-
resource_id: "bar",
4947
});
5048

5149
it("Has the PowerShell script install Devolutions Gateway", async () => {
5250
const state = await runTerraformApply<TestVariables>(import.meta.dir, {
5351
agent_id: "foo",
54-
resource_id: "bar",
5552
});
5653

5754
const lines = findWindowsRdpScript(state)
@@ -96,7 +93,6 @@ describe("Web RDP", async () => {
9693
import.meta.dir,
9794
{
9895
agent_id: "foo",
99-
resource_id: "bar",
10096
},
10197
);
10298

@@ -116,7 +112,6 @@ describe("Web RDP", async () => {
116112
import.meta.dir,
117113
{
118114
agent_id: "foo",
119-
resource_id: "bar",
120115
admin_username: customAdminUsername,
121116
admin_password: customAdminPassword,
122117
},

registry/coder/modules/windows-rdp/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ variable "admin_password" {
4848

4949
variable "devolutions_gateway_version" {
5050
type = string
51-
default = "2025.2.1"
51+
default = "2025.2.2"
5252
description = "Version of Devolutions Gateway to install. Defaults to the latest available version."
5353
}
5454

0 commit comments

Comments
 (0)