Skip to content

Encrypt sensitive data #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
SalmaElsoly wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Encrypt sensitive data #528

SalmaElsoly wants to merge 15 commits into from

Conversation

@SalmaElsoly
Copy link
Contributor

@SalmaElsoly SalmaElsoly commented Sep 15, 2025 •
edited
Loading

Description

Changes

  • Crypto added: implemented CryptoManager with AES-GCM + Argon2 KDF; added initializer to encrypt legacy mnemonics at startup.
  • Mnemonic storage: switched models.User.Mnemonic from string to []byte (ciphertext bytes).
  • Decryption usage: handlers now decrypt user.Mnemonic before use across admin, user, node, deployment, balance monitor, debt tracker, and money collector.

Related Issues

#88

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstring

@SalmaElsoly SalmaElsoly force-pushed the master_encrypt_data branch 2 times, most recently from 8efe478 to c68416d Compare September 16, 2025 09:01
@SalmaElsoly SalmaElsoly marked this pull request as ready for review September 16, 2025 13:26
@SalmaElsoly SalmaElsoly marked this pull request as draft September 16, 2025 13:26
@SalmaElsoly SalmaElsoly marked this pull request as ready for review September 16, 2025 13:56
AlaaElattar
AlaaElattar reviewed Sep 17, 2025
View reviewed changes
@SalmaElsoly SalmaElsoly marked this pull request as draft September 18, 2025 06:16
@SalmaElsoly SalmaElsoly force-pushed the master_encrypt_data branch 2 times, most recently from 6ebe5fc to 73fd76f Compare September 21, 2025 10:17
@SalmaElsoly SalmaElsoly marked this pull request as ready for review September 21, 2025 11:20
@SalmaElsoly
feat(crypto): implement encryption and decryption for mnemonics
0db902c
@SalmaElsoly
integrate mnemonic encryption in user registration process
34e0668
@SalmaElsoly
refactor: replace user mnemonic usage with decrypted mnemonic across …
da8ccb1 
…multiple handlers
@SalmaElsoly
feat(admin): handle users with empty mnemonics and derive account add…
f0b717e 
…resses from mnemonics
@SalmaElsoly
refactor: update mnemonic to be saved as bytes
d1fa638
@SalmaElsoly
add required for argon2 configs
21d6261
@SalmaElsoly
fix: cleanup can't read decryption configs
61ed838
@SalmaElsoly
test: add property-based tests for encryption and decryption of mnemo…
d4933fb 
…nics
@SalmaElsoly
feat: add flags for mnemonic encryption configuration
000d8ea
@SalmaElsoly
fix conflicts
56fd40b
@SalmaElsoly
feat: encrypt kube config
e6b5415
@SalmaElsoly
refactor: rename mnemonic encryption fields to general encryption terms
f023a79
@SalmaElsoly
fix linting
75c0e5e
@SalmaElsoly
fix tests
340d93a
@SalmaElsoly
style: align formatting of cryptoMgr field in user handler
3086f25
@SalmaElsoly SalmaElsoly marked this pull request as draft October 20, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AlaaElattar AlaaElattar AlaaElattar left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SalmaElsoly @AlaaElattar