-
Notifications
You must be signed in to change notification settings - Fork 1
Feat add redis distributed locking mechanism #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SalmaElsoly
wants to merge
10
commits into
master
Choose a base branch
from
master_distributed_locks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d0623bd to
ec85e80
Compare
xmonader
reviewed
Nov 30, 2025
xmonader
reviewed
Nov 30, 2025
ec85e80 to
2ec13a8
Compare
98ef89d to
2884a17
Compare
2884a17 to
3da4962
Compare
3da4962 to
6c8bbc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a distributed locking mechanism for nodes using Redis, to keep node resources synchronized
Changes
DistributedLocksinterface and a Redis-based implementation (RedisLocker) for managing node and workflow locks, including methods to acquire, release, and query locks.NodeHandlerandDeploymentHandlerto use the distributed locking mechanism. Now, before performing operations like reserving a node, deploying a cluster, or adding a node, the handlers attempt to acquire locks on the relevant nodes. If a node is already locked, the request will be rejected with a conflict error.Related Issues
#872
Checklist