Fallback to a healthy master if the leader node is down #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalmaElsoly
requested changes
Dec 25, 2025
Comment on lines
+101
to
+106
| for _, n := range cluster.Nodes { | ||
| if n.Type == NodeTypeMaster && n.Healthy { | ||
| leaderIP = n.IP | ||
| log.Debug().Str("node_name", n.Name).Str("node_ip", n.IP).Msg("Using alternative healthy master") | ||
| break | ||
| } |
Contributor
There was a problem hiding this comment.
what will happen if there was no alternative node? I think we should return an error in that case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fallback to a healthy master is the leader is down
Changes
fallback to a healthy master is the leader is down for deploy node, batch deploy nodes
Related Issues
#948
Checklist