Partial rewrite in TypeScript #692
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apollon77
requested changes
May 13, 2025
There was a problem hiding this comment.
Sorry for the late review, but here we go. Thats a cool start. I have some smaller comments - and sorry that you need to rebase because of some fixes I did :-(
Formatting wise please stay with spaces instead of tabs .. I am fully ok with 4 spaces, but please no tabs :-)
| "p-timeout": "3.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@biomejs/biome": "^1.9.4", |
There was a problem hiding this comment.
I personallymore tend to stay with eslint and prettier than using "just another package that somehow contains simmilar things" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of TuyAPI in TypeScript.
There are lots of things in the code I don't understand so I refrained from rewriting them to avoid introducing new issues. So this is only a partial rewrite, most of the code has been rewritten, except for
index.jswhich still has lot of unrtyped code.From #691