Skip to content

Update UserOperation status to support string comparison #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohan-agarwal-coinbase merged 4 commits into from
Feb 27, 2025
Merged

Update UserOperation status to support string comparison #115

rohan-agarwal-coinbase merged 4 commits into from
Feb 27, 2025

Conversation

@rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Feb 27, 2025 •
edited
Loading

What changed? Why?

  • @CarsonRoscoe discovered that doing userOperation.status == 'complete' doesn't work since it's an enum. This PR makes it possible to do a string comparison

Testing

  • Added unit test that succeeds after these code changes
  • Tested E2E to see that string comparison work

@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit 27b6931 into v0.21.0 Feb 27, 2025
8 checks passed
rohan-agarwal-coinbase added a commit that referenced this pull request Feb 28, 2025
@rohan-agarwal-coinbase
Releasing v0.21.0 (#117)
34bd2c2 
* Improve error message when SDK is used and not initialized (#114)

* Update UserOperation status to support string comparison (#115)

* Preparing v0.21.0 release (#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jazz-cb jazz-cb jazz-cb approved these changes

@alex-stone alex-stone Awaiting requested review from alex-stone

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohan-agarwal-coinbase @jazz-cb