Support for fund and quote_fund for wallet funding #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
alex-stone
reviewed
Nov 27, 2024
alex-stone
approved these changes
Nov 27, 2024
Contributor
alex-stone
left a comment
alex-stone
left a comment
There was a problem hiding this comment.
Looks good, there are some minor differences in the amount / types and rendering here, but we can always align those later
Merged
alex-stone
added a commit
that referenced
this pull request
Nov 27, 2024
* Fix Asset from_model bug to use passed in asset_id when initializing (#46) * Support for fund and quote_fund for wallet funding (#47) * Fix quote fund to properly pass in normalized amount (#50) * Contract webhook support (#52) * contract activity webhook support * Update webhook.py * Update webhook_factory.py * chore: Prep v0.11.0 release (#51) --------- Co-authored-by: rohan-agarwal-coinbase <[email protected]> Co-authored-by: cb-howardatcb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Testing
Qualified Impact